Zoe .d.ts libcheck #9374
Merged
Zoe .d.ts libcheck #9374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
commented
May 16, 2024
| @@ -67,8 +66,6 @@ test(`zoe - wrongly throw zcfSeat.exit()`, async t => { | |||
|
|
|||
| /** @type {OfferHandler} */ | |||
| const throwSeatFail = seat => { | |||
| // @ts-expect-error Linting correctly identifies that the argument to | |||
There was a problem hiding this comment.
fail actually takes Details which is string | DetailsToken.
turadg
commented
May 16, 2024
| const zcf = testJig.zcf; | ||
|
|
||
| /** @type {OfferHandler} */ | ||
| const throwSeatExit = seat => { | ||
| // @ts-expect-error Linting correctly identifies that exit takes no argument. |
There was a problem hiding this comment.
exit actually takes an optional Completion which is any non-thenable Passable
dckc
approved these changes
May 16, 2024
Comment on lines
254
to
255
| consume: Record<WellKnownName['instance'], Promise<Instance>> & { | ||
| // not worth defining for all contracts. One here just for testing getPublicFacet(instance) |
Deploying agoric-sdk with
|
| Latest commit: |
72b3b76
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6f5b64c5.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-zoe-getpublicfacet.agoric-sdk.pages.dev |
Chris-Hibbert
approved these changes
May 16, 2024
turadg
force-pushed
the
ta/zoe-GetPublicFacet
branch
from
9a45da8 to
72b3b76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9364
Description
Follow-up to #9364, also doing the
skipLibCheck: falsefor Zoe package and fixing up most of the issues. (Documenting the deferred).Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations
just types and tests. will not affect production but small impact on release process (cherry picking)