Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273 remove custom Ava glob #9352

Merged
merged 1 commit into from
May 28, 2024
Merged

8273 remove custom Ava glob #9352

merged 1 commit into from
May 28, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented May 8, 2024

closes: #8273

Description

#8653 adopted the new glob but left the old one so any in-flight PRs with new tests wouldn't have them ignored.

It's been a month so any should be migrated by now. This removes the old glob.

It doesn't remove the "files" option entirely, because the default glob is everything under test and we have files there that aren't tests. Ava warns they're not tests and and eslint errors when tests import from them. We could go fully to the default glob by using an underscore prefixes on files in test that aren't tests. I don't think we need to do that. This change already meets the goal of matching the DX of Ava in other repos. (Test filenames are indicated by a .test.js suffix)

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

reduces need to document

Testing Considerations

no older test files in master (find packages -name 'test-*' |grep 'test/')

Upgrade Considerations

n/a

Copy link

cloudflare-workers-and-pages bot commented May 8, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: f678160
Status: ✅  Deploy successful!
Preview URL: https://885e11ab.agoric-sdk.pages.dev
Branch Preview URL: https://8273-expand-glob.agoric-sdk.pages.dev

View logs

@turadg turadg requested review from Chris-Hibbert and kriskowal May 8, 2024 22:23
@turadg turadg marked this pull request as draft May 10, 2024 16:18
@turadg turadg changed the title 8273 expand glob 8273 remove custom Ava glob May 28, 2024
@turadg turadg force-pushed the 8273-expand-glob branch from 9c8ab44 to 468a28e Compare May 28, 2024 15:33
@turadg turadg marked this pull request as ready for review May 28, 2024 15:33
@turadg turadg force-pushed the 8273-expand-glob branch from 468a28e to a1988df Compare May 28, 2024 16:31
@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label May 28, 2024
@turadg turadg force-pushed the 8273-expand-glob branch from a1988df to f678160 Compare May 28, 2024 18:21
@mergify mergify bot merged commit 1933b27 into master May 28, 2024
65 checks passed
@mergify mergify bot deleted the 8273-expand-glob branch May 28, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adopt Ava default files glob
2 participants