fix(base-zone,zone): import isPassable from @endo/pass-style
#9230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
979fe17
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f300c455.agoric-sdk.pages.dev |
| Branch Preview URL: | https://markm-delegate-is-passable.agoric-sdk.pages.dev |
erights
force-pushed
the
markm-delegate-is-passable
branch
from
fd57c61 to
d4ef47a
Compare
erights
changed the title
isPassable from @endo/pass-style
michaelfig
requested changes
Apr 23, 2024
There was a problem hiding this comment.
Here is a way to mark a conventional commit as a breaking change (note that the parenthesised portion of the commit message cannot contain commas):
fix(base-zone)!: do not export `isPassable`; it is available from `@endo/pass-style`
d4ef47a to
978b621
Compare
erights
force-pushed
the
markm-delegate-is-passable
branch
from
a644c32 to
3ba8c71
Compare
|
PTAL, thanks |
michaelfig
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: endojs/endo#2096 endojs/endo#2042
Description
Deleting @agoric/base-zone's implementation of
isPassablecompletes the migration ofisPassablefrom @agoric/base-zone to @endo/pass-style explained in endojs/endo#2096 and started in endojs/endo#2042The remaining issue explained in endojs/endo#2096 , changing how
isPassableis implemented, remains to be done in @endo/pass-style. But this need no longer concern us here since that difference will now be encapsulated from us.Security Considerations
None
Scaling Considerations
We know that
passStyleOfremains a performance hotspot that needs attention. This PR does not affect that at all. But I'll note that the remaining suggested change from endojs/endo#2096 --- to implementisPassableandpassStyleOfin terms of a more expressive internal function parameterized by a checker --- might make this performance issue worse. Just something to keep in mind as we tunepassStyleOf. Attn @gibson042Documentation Considerations
none
Testing Considerations
none
Upgrade Considerations
As of this PR, @agoric/base-zone also no longer exports
isPassable, potentially breaking importers outside agoric-sdk until they are modified to import it from @endo/pass-style as well. This PR does take care of all such import sites within agoric-sdk.If this turns out to be a problem in practice, this PR could be changed to have @agoric/base-zone reexport the
isPassableit imports from @endo/pass-style, but deprecate that reexport, leaving it to future work to change those old import sites outside agoric-sdk.