Upgrade VaultFactory in A3P, and use new auctions and price feeds #8757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
force-pushed
the
auctioneer-private-args-cth
branch
2 times, most recently
from
03f4000 to
a289edc
Compare
Chris-Hibbert
force-pushed
the
auctioneer-private-args-cth
branch
from
a289edc to
02a24db
Compare
14 tasks
Chris-Hibbert
force-pushed
the
auctioneer-private-args-cth
branch
3 times, most recently
from
8354228 to
95dc762
Compare
Chris-Hibbert
changed the title
Chris-Hibbert
changed the title
Chris-Hibbert
force-pushed
the
auctioneer-private-args-cth
branch
from
95dc762 to
f9b13c1
Compare
Chris-Hibbert
force-pushed
the
auctioneer-private-args-cth
branch
from
f7caf03 to
9c83369
Compare
Chris-Hibbert
force-pushed
the
8740-newAuction
branch
from
44189f6 to
49f7ded
Compare
Chris-Hibbert
force-pushed
the
auctioneer-private-args-cth
branch
2 times, most recently
from
c905c65 to
293ead0
Compare
Chris-Hibbert
force-pushed
the
auctioneer-private-args-cth
branch
from
293ead0 to
3d5be31
Compare
Deploying agoric-sdk with
|
| Latest commit: |
a30f7be
|
| Status: | 🚫 Build failed. |
Chris-Hibbert
force-pushed
the
8740-newAuction
branch
from
49f7ded to
ff78434
Compare
Chris-Hibbert
force-pushed
the
auctioneer-private-args-cth
branch
from
0bcf9d5 to
78a39ce
Compare
Chris-Hibbert
force-pushed
the
auctioneer-private-args-cth
branch
from
e1e0b2f to
7bad3e3
Compare
Chris-Hibbert
force-pushed
the
auctioneer-private-args-cth
branch
from
7bad3e3 to
2718ca9
Compare
Chris-Hibbert
force-pushed
the
auctioneer-private-args-cth
branch
from
2718ca9 to
a30f7be
Compare
Chris-Hibbert
force-pushed
the
8740-newAuction
branch
2 times, most recently
from
3774694 to
2d5a66a
Compare
mergify bot
added a commit
that referenced
this pull request
Apr 29, 2024
refs: #8740 closes: #8918 refs: #8400 ## Description Add a new Auction instance in A3P, so #8757 can make use of it. Also provides upgrade proposals which can be be applied to MainNet and other chains. ### Security Considerations N/A ### Scaling Considerations This is largely in service of #8400, which reports that priceFeed vats are accumulating garbage. This PR gives a new auction which can rely on new priceFeeds. The existing auction is not upgradeable and its pricefeeds can't be updated. ### Documentation Considerations No user-visible changes to behavior. ### Testing Considerations Tested in A3P ### Upgrade Considerations Auctions are not upgradeable, so we have to replace them and update their clients.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8049
closes: #8740
refs: #8868
closes: #8918
closes: #8981
closes: #8079
refs: #8400
closes: #8735
closes: #7873
closes: #8726
closes: #7954
Description
Upgrade VaultFactory in A3P, relying on the new PriceFeeds, and auctions. The actual upgrade waits for the priceFeeds to start supplying before doing the upgrade, so there won't be any gap in priceUpdates.
When the upgrade is finished, we also update the auctioneerKit and Auction instance in the bootstrap environment.
This PR demonstrates that VaultFactory can be upgraded even though governance is not persistent (#8123).
Security Considerations
N/A
Scaling Considerations
This is largely in service of #8400, which reports that priceFeed vats are accumulating garbage. This PR switches to new priceFeeds, which won't have that problem, though cleaning up the existing vats is a task for the future.
Documentation Considerations
No changes to user-visible behavior.
Testing Considerations
Tests don't pass yet.
Upgrade Considerations
Upgrade all the vats!