Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(SwingSet): convert run-utils.ts to JS #8659

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

michaelfig
Copy link
Member

Description

So that SwingSet remains a "Just Javascript" package, convert tools/run-utils.ts from Typescript to Javascript.

Best reviewed without whitespace changes.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

n/a

Upgrade Considerations

n/a

@michaelfig michaelfig added the SwingSet package: SwingSet label Dec 14, 2023
@michaelfig michaelfig self-assigned this Dec 14, 2023
@michaelfig michaelfig requested review from turadg and dckc December 14, 2023 21:54
@michaelfig michaelfig marked this pull request as ready for review December 14, 2023 21:56
@michaelfig michaelfig changed the title chore(SwingSet): convert run-utils.ts to JS refactor(SwingSet): convert run-utils.ts to JS Dec 14, 2023
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's harder to read now but worth it on balance for keeping this package just .js.

Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered whether the main SwingSet maintainers were aware that some .ts got in to the package. Some spelunking shows it was don in 699d9e1 , which was written by Chip and reviewed by warner. So I'm a little ambivalent about this change.

I'm still don't have enough experience to be comfortable with typescript beyond .d.ts files, so I guess I'm happy in that sense.

@dckc
Copy link
Member

dckc commented Dec 14, 2023

I'm a little surprised that there are no changes to package.json to turn off tsx tooling. I suppose those settings are global to the monorepo?

@turadg
Copy link
Member

turadg commented Dec 14, 2023

little surprised that there are no changes to package.json to turn off tsx tooling

This file was imported in exactly two places (packages/boot and packages/benchmark), and they both still need the tsx loader.

@michaelfig michaelfig added the automerge:no-update (expert!) Automatically merge without updates label Dec 14, 2023
@mergify mergify bot merged commit d61be8d into master Dec 14, 2023
88 checks passed
@mergify mergify bot deleted the mfig-run-utils-js branch December 14, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:no-update (expert!) Automatically merge without updates SwingSet package: SwingSet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants