export types from timer package #8631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
approved these changes
Dec 7, 2023
turadg
force-pushed
the
ta/timer-types
branch
from
d3d7efa to
5406a34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While doing a code review with @0xpatrickdev and @dckc we saw a typedef for
setWakeupthat did not have the cancel taoken. That was a stale one in Zoe from 3 yrs ago.This instead import
TimerServicefrom@agoric/time. To do that I had to export the type from index instead of the deepsrc/types. Once that was done I want ahead and simplified all the deep imports.Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations