feat(create-dapp): npm create @agoric/dapp ... uses agoric init
#8530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
mfig-create-dapp
branch
from
f94a0d5 to
0213496
Compare
michaelfig
changed the base branch from
hack-getting-started
to
release-getting-started
michaelfig
force-pushed
the
mfig-create-dapp
branch
from
d5b42a9 to
0800b1e
Compare
mhofman
approved these changes
Nov 14, 2023
1 task
mhofman
pushed a commit
that referenced
this pull request
Jan 30, 2024
feat(create-dapp): `npm create @agoric/dapp ...` uses `agoric init`
mhofman
pushed a commit
that referenced
this pull request
Jan 30, 2024
feat(create-dapp): `npm create @agoric/dapp ...` uses `agoric init`
mhofman
pushed a commit
that referenced
this pull request
Jan 30, 2024
feat(create-dapp): `npm create @agoric/dapp ...` uses `agoric init`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in
packages/create-dapp/README.md: To make a new Agoric Dapp in thefoosubdirectory, you can use:[...]
Each of the above commands are shorthand for installing the
agoricpackage, then runningagoric init foo.Security Considerations
No more than the existing considerations for
agoric init.Scaling Considerations
n/a
Documentation Considerations
Will need documentation if Product Management decides this is a feature we should advertise.
Testing Considerations
Only basic sanity tests so far. Should be further explored as part of CI.
Upgrade Considerations
n/a