fix liveslots types #8519
Merged
fix liveslots types #8519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
commented
Nov 9, 2023
| @@ -322,7 +322,7 @@ const insistSameCapData = (oldCD, newCD) => { | |||
| * recursion if our returned WeakMap/WeakSet wrappers are subsequently installed | |||
| * on globalThis. | |||
| * | |||
| * @returns {object} a new virtual object manager. | |||
There was a problem hiding this comment.
object is any so this erased the type information about the function return
turadg
force-pushed
the
ta/liveslots-types
branch
from
f48eac7 to
5577c4f
Compare
|
@Mergifyio requeue |
☑️ This pull request is already queued |
turadg
force-pushed
the
ta/liveslots-types
branch
from
5577c4f to
f7ac76c
Compare
erights
approved these changes
Nov 10, 2023
Temporary error in the integration tests. I've kicked it off again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed some typing deficiencies in #8453
This addresses them.
Security Considerations
--
Scaling Considerations
--
Documentation Considerations
--
Testing Considerations
Some regression test added. Others "enabled" by removing suppressions.
Upgrade Considerations
--