Swingset startup & benchmark plumbing for node/v8 per-vat profiling & debugging #8491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUDCo
added
enhancement
FUDCo
force-pushed
the
refactor-bootstrap-test-support
branch
from
1995bde to
3f9f8ba
Compare
FUDCo
force-pushed
the
control-profiling
branch
2 times, most recently
from
0374b46 to
4cc5873
Compare
gibson042
approved these changes
Dec 8, 2023
Comment on lines
+15
to
+21
| if (profileVats.includes(vatID)) { | ||
| args.push('--cpu-prof'); | ||
| args.push('--cpu-prof-interval'); | ||
| args.push('100'); | ||
| args.push('--cpu-prof-name'); | ||
| args.push(`CPU.${nameDisplayArg}.cpuprofile`); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (profileVats.includes(vatID)) { | |
| args.push('--cpu-prof'); | |
| args.push('--cpu-prof-interval'); | |
| args.push('100'); | |
| args.push('--cpu-prof-name'); | |
| args.push(`CPU.${nameDisplayArg}.cpuprofile`); | |
| } | |
| if (profileVats.includes(vatID)) { | |
| // cf. https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_282 | |
| const fsNameDisplay = nameDisplayArg.replaceAll(':', '-').replaceAll(/[^a-z0-9._-]/gi, '_'); | |
| args.push('--cpu-prof'); | |
| args.push('--cpu-prof-interval'); | |
| args.push('100'); | |
| args.push('--cpu-prof-name'); | |
| args.push(`vat-${fsNameDisplay}.cpuprofile`); | |
| } |
(or similar)
There was a problem hiding this comment.
I think all of your doc suggestions are excellent, but I was literally seconds from tagging the PR for merge when your comments came and I'm reluctant to hold up the train at this stage (since there are a couple of other things waiting for it). So my plan is to land this now as is and incorporate your proposed doc improvements as a follow-on PR.
FUDCo
force-pushed
the
control-profiling
branch
from
4cc5873 to
b680821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8490