Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc types cleanup #8428

Closed
wants to merge 3 commits into from
Closed

misc types cleanup #8428

wants to merge 3 commits into from

Conversation

turadg
Copy link
Member

@turadg turadg commented Oct 3, 2023 •
edited
Loading

refs: endojs/endo#1798

Description

Adds a patch to fix endojs/endo#1798 until endojs/endo#1799 is published and adopted in this repo.

Includes some other types fixes that were ready to go.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

CI

Upgrade Considerations

n/a

@turadg turadg requested review from mhofman and FUDCo October 3, 2023 22:10
mhofman
mhofman approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch is fine (same as I provided). Rest seems fine, but I didn't review thoroughly

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Oct 3, 2023
FUDCo
FUDCo approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well ok then

@erights
Copy link
Member

erights commented Oct 4, 2023

Curious how the other changes came to need the patch change. What broke when only the patch was omitted?

This question is completely non-urgent. Do not delay merging this PR to answer. Thanks.

@turadg
Copy link
Member Author

turadg commented Oct 4, 2023

Curious how the other changes came to need the patch change. What broke when only the patch was omitted?

83b1fc8 is the only thing needed for the stack traces. The other two commits were misc cleanup

@turadg turadg marked this pull request as draft October 4, 2023 00:19
@turadg
Copy link
Member Author

turadg commented Oct 4, 2023

reverting to draft because we're still seeing line 1 traces (e.g. packages/boot/test/bootstrapTests/test-demo-config.ts:1:1038)

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

@turadg - This PR appears to be stuck. It's had a merge label for > 24 hours

@turadg turadg removed the automerge:rebase Automatically rebase updates, then merge label Oct 5, 2023
@turadg turadg mentioned this pull request Oct 5, 2023
Draft
@erights erights self-assigned this Jul 12, 2024
@erights
Copy link
Member

erights commented Jul 12, 2024 •
edited
Loading

Hi @turadg , as a draft this was unassigned. I went ahead and assigned myself as I intend to look at the stack-trace-info-loss portion of this, and hopefully make progress.

@turadg
Copy link
Member Author

turadg commented Oct 4, 2024

Solved by endojs/endo#2355

@turadg turadg closed this Oct 4, 2024
@turadg turadg deleted the ta/types-cleanup branch October 4, 2024 23:05
@turadg turadg restored the ta/types-cleanup branch October 4, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FUDCo FUDCo FUDCo approved these changes

@mhofman mhofman mhofman approved these changes

Assignees

@erights erights

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v8 error taming should leverage prepareStackTrace
4 participants
@turadg @erights @mhofman @FUDCo