-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishable NPM packages for mainnet #8360
Publishable NPM packages for mainnet #8360
Conversation
ci(local-npm): resume integration testing of NPM canary
often takes 20min in production. allow 40 for future cases (e.g. Endo)
workaround for #8091
@michaelfig I'm not sure what is failing in the getting-started tests. |
781c700
to
1bd0c31
Compare
It's an old
Fixed by @turadg in https://github.com/endojs/endo/blob/5b8e97b445e0da0c92b2496cda574321f6758c34/packages/bundle-source/package.json#L42 |
That's what I just figured out. Are we ok with just yarn support then ? Still weird that yarn doesn't puke, I guess because of a different |
1bd0c31
to
04b2461
Compare
Now I see the getting-started test is timing out. I'm not sure why. |
8355af4
to
58a6d49
Compare
58a6d49
to
1f26562
Compare
@warner @michaelfig I have confirmed in local tests, CI and manual |
735b9bf
to
7c596b9
Compare
7c596b9
to
8f8782b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhofman walked me through the need for this, and the solution they picked, and it sounds good to me
Agoric/agoric-sdk#8360 caused errors with Endo lockdown in Ava tests
Agoric/agoric-sdk#8360 caused errors with Endo lockdown in Ava tests
Fixes #8366
Description
The NPM packages generated by the
release-mainnet1B
branch, including the ones related toagoric-upgrade-11
are broken in various ways such that they are unusable to develop a dapp usingagoric-sdk
packages installed from NPM. Most of these issues have been fixed in trunk since then. This backports build changes to make published NPM packages work for therelease-mainnet1B
branch.In particular:
npm
andnpx
#8250 and Sync Endo: 2023-08-08 #8314@endo/*
package versions to avoid picking up newer published endo versions when installing from NPM (theagoric-sdk
yarn.lock
does not apply). This is needed because some endo changes are more breaking than advertised.This branch was constructed as follow:
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Locally tested using
scripts/registry.sh ci
. Will check CI integration tests as wellUpgrade Considerations
This should have no impact on a future chain software upgrade that includes these changes.
We should follow up this PR by going through the release process and publish new NPM packages with the appropriate dist tag.
agoric-upgrade-11
may be appropriate.