-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert boot
tests to .ts
#8313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
ta/ts-tests
branch
2 times, most recently
from
September 15, 2023 23:06
48d7dcc
to
fbf6682
Compare
iomekam
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❇️
we're aware of the experimental nature
dckc
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gather this is likely to facilitate upcoming tests for multiple collaterals.
turadg
added a commit
that referenced
this pull request
Sep 19, 2023
#8313 changed supports module to .ts
Merged
turadg
added a commit
that referenced
this pull request
Sep 19, 2023
#8313 changed supports module to .ts
anilhelvaci
pushed a commit
to Jorge-Lopes/agoric-sdk
that referenced
this pull request
Feb 16, 2024
Agoric#8313 changed supports module to .ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts
bootstrapTests
to use.ts
syntax.To support running
.ts
in tests, it configures Ava in@agoric/boot
to use thetsx
loader. It also adds a Node option to suppress the warnings about using an experimental feature. There will always be some way to load TS files so whatever API changes are required by future versions of Node, we will adopt as we upgrade.Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
Developers should be informed. I think we covered that in a meeting today.
Testing Considerations
Tests per se
Upgrade Considerations
n/a