types for deployment scripts #7895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re documentation considerations: Discussions don't seem to automatically back-link the way issues and PRs do. |
turadg
force-pushed
the
ta/deployment-types
branch
from
0d4bab8 to
53a6ed3
Compare
Deploying agoric-sdk with
|
| Latest commit: |
6864614
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9d6c9ba6.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-deployment-types.agoric-sdk.pages.dev |
dckc
approved these changes
Oct 23, 2024
| * namesByAddress: ERef<NameHub>, | ||
| * scratch: ERef<import('@agoric/internal/src/scratch.js').ScratchPad>, | ||
| * zoe: ERef<ZoeService>, | ||
| * }} CanonicalHome |
There was a problem hiding this comment.
Maybe add a note that home only works in ag-solo mode?
| * publishBundle: PublishBundleRef, | ||
| * pathResolve: (...path: string[]) => string, | ||
| * cacheDir: string, | ||
| * }} DeployScriptEndownments |
There was a problem hiding this comment.
very nice.
I don't see this in/near https://agoric-sdk.pages.dev/modules/_agoric_deploy_script_support . I guess that's not essential to the IDE use case, though.
turadg
force-pushed
the
ta/deployment-types
branch
from
53a6ed3 to
6864614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental (I was cleaning out old PRs and thought this was worth getting into master.)
Description
This defines a
DeployScriptFunctiontype and marks many deploy script functions with it. The value of this is someone can command-click through the code to see how it's supposed to work and what the expected endowments are.To get that working I also had to fix some of the types for bundling, which is another value of landing this.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
We might want to document these scripts better but this doesn't create any new work.
Testing Considerations
Should not affect runtime