chore(cosmic-swingset): Add phase to cosmic-swingset-run-{start,finish} slog entries
#10765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #10752.
Add
phase: "{leftover,forced,high-priority,timer,queued,cleanup}"to cosmic-swingset-run{start,finish} slogfile entries (see launch-chain.js, particularlyprocessBlockActions).Security Considerations
None known.
Scaling Considerations
The size increase should be modest, and I believe pays for itself in increased transparency.
Documentation Considerations
n/a
Testing Considerations
Already seen working in #10752.
Upgrade Considerations
None known, although we will probably want slog-to-otel consumption of the new data.