-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PSM upgrade for upgrade-19 #10730
base: master
Are you sure you want to change the base?
Conversation
Deploying agoric-sdk with Cloudflare Pages
|
The Upgrade Considerations section is a copy of the one from #10541. Please consider the differences and re-write. |
I see that you included the |
@@ -0,0 +1,80 @@ | |||
/* eslint-env node */ | |||
/** | |||
* @file The goal of this file is to make sure v36-reserve upgraded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy-paste error
* 1. Simulate trade of IST and USDC | ||
* 2. Upgrade all PSMs | ||
* 3. Verify metrics are the same after the upgrade | ||
* 4. Verity trading is still possible after the upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
* 4. Verity trading is still possible after the upgrade | |
* 4. Verify trading is still possible after the upgrade |
}; | ||
}); | ||
|
||
test.serial('similate trade of IST and USDC', async t => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
test.serial('similate trade of IST and USDC', async t => { | |
test.serial('simulate trade of IST and USDC', async t => { |
console.log('[CONTRACT_KITS]', contractKits); | ||
console.log('[ISSUER]', usdcIssuer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why print the square brackets?
} | ||
} | ||
|
||
console.log('Minting USDC'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break if it doesn't find a usdcMint. We should add an assertion so it'll fail deliberately if there are testnets where it's not found?
console.log(await E(seat).getPayouts()); | ||
console.log('Done.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a comment here that the success will be checked in the test by reading from vstorage.
closes: #10403
Description
Adds the upgrade of the psm contracts to upgrade 19. To ensure that this upgrade will succeed, we've also added test coverage in A3P.
Upgrade Considerations
This PR adds the PSM contract to the list of vat upgrades. The PSM upgrade proposal will upgrade all PSM instances on the chain. We've added A3P tests to ensure that the upgrade is successful and that assets are still in the reserve after the upgrade.