Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PSM upgrade for upgrade-19 #10730

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add PSM upgrade for upgrade-19 #10730

wants to merge 8 commits into from

Conversation

iomekam
Copy link
Contributor

@iomekam iomekam commented Dec 18, 2024

closes: #10403

Description

Adds the upgrade of the psm contracts to upgrade 19. To ensure that this upgrade will succeed, we've also added test coverage in A3P.

Upgrade Considerations

This PR adds the PSM contract to the list of vat upgrades. The PSM upgrade proposal will upgrade all PSM instances on the chain. We've added A3P tests to ensure that the upgrade is successful and that assets are still in the reserve after the upgrade.

Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 03c583b
Status: ✅  Deploy successful!
Preview URL: https://d4613d43.agoric-sdk.pages.dev
Branch Preview URL: https://iomekam-psm-upgrade.agoric-sdk.pages.dev

View logs

@iomekam iomekam added the force:integration Force integration tests to run on PR label Dec 20, 2024
@iomekam iomekam marked this pull request as ready for review December 20, 2024 14:10
@iomekam iomekam requested a review from a team as a code owner December 20, 2024 14:10
@Chris-Hibbert
Copy link
Contributor

The Upgrade Considerations section is a copy of the one from #10541. Please consider the differences and re-write.

@Chris-Hibbert
Copy link
Contributor

I see that you included the force-integration flag, but it didn't actually run the Integration tests / test-docker-build test. Would you poke it again and see if you can get it to run these tests? I'd like to review the run output.

@@ -0,0 +1,80 @@
/* eslint-env node */
/**
* @file The goal of this file is to make sure v36-reserve upgraded.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy-paste error

* 1. Simulate trade of IST and USDC
* 2. Upgrade all PSMs
* 3. Verify metrics are the same after the upgrade
* 4. Verity trading is still possible after the upgrade
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Suggested change
* 4. Verity trading is still possible after the upgrade
* 4. Verify trading is still possible after the upgrade

};
});

test.serial('similate trade of IST and USDC', async t => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Suggested change
test.serial('similate trade of IST and USDC', async t => {
test.serial('simulate trade of IST and USDC', async t => {

Comment on lines 16 to 17
console.log('[CONTRACT_KITS]', contractKits);
console.log('[ISSUER]', usdcIssuer);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why print the square brackets?

}
}

console.log('Minting USDC');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break if it doesn't find a usdcMint. We should add an assertion so it'll fail deliberately if there are testnets where it's not found?

Comment on lines 50 to 51
console.log(await E(seat).getPayouts());
console.log('Done.');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment here that the success will be checked in the test by reading from vstorage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract Upgrade: 8 PSM contracts
2 participants