chore(fusdc): settle ForwardFailed and Advancing txs
#10729
Draft
+661
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
066f108
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d1dad169.agoric-sdk.pages.dev |
| Branch Preview URL: | https://pc-10625-forward-failed.agoric-sdk.pages.dev |
dckc
reviewed
Dec 18, 2024
Comment on lines
167
to
175
| } catch (e) { | ||
| // settlement already received; tx will Forward. |
There was a problem hiding this comment.
assuming all exceptions have this meaning seems inconsistent with https://github.com/Agoric/agoric-sdk/wiki/Errors-and-Control-Flow
| if (mintedEarly.has(key)) { | ||
| mintedEarly.delete(key); | ||
| void this.facets.self.forward(txHash, fullValue, destination.value); | ||
| throw Fail`${q(txHash)} minted before Observed`; |
There was a problem hiding this comment.
This should be "raising a non-error" per house style on Errors and Control Flow
0xpatrickdev
force-pushed
the
pc/10625-forward-failed
branch
from
d044624 to
28e969b
Compare
- tx to Forward will always have `txHash` - `Advancing` txs can be dequeued and added to `mintedEarly` - handle "minted before Observed" by adding to `mintedEarly` store - `Advancer` checks if tx is in `mintedEarly` store
- use `notifyFacet` is used to simulate Advance - test that "minted early" forwards if evidence eventually reported - test `ForwardFailed` state (slow `.forward` transfer fails) - test "minted while `Advancing`" scenarios (`Advanced`, `AdvanceFailed`)
0xpatrickdev
force-pushed
the
pc/10625-forward-failed
branch
from
28e969b to
f5df91a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10625
Description
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations