Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator attestation policy #10721

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Operator attestation policy #10721

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
caf6d7a
chore: constrain fast-usdc config for Mainnet
turadg Dec 17, 2024
621e22f
test: disabled operators
turadg Dec 17, 2024
0b57a65
refactor: TransactionFeed attest
turadg Dec 17, 2024
1e52a41
refactor: sync submitEvidence
turadg Dec 17, 2024
fb4ff30
refactor: attest by operatorId
turadg Dec 17, 2024
bc28201
feat: operator majority logic
turadg Dec 17, 2024
cd2a40c
feat: error on conflicting evidence
turadg Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/fast-usdc/src/exos/operator-kit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const trace = makeTracer('TxOperator');

/**
* @typedef {object} OperatorPowers
* @property {(evidence: CctpTxEvidence, operatorKit: OperatorKit) => void} submitEvidence
* @property {(evidence: CctpTxEvidence, operatorKit: OperatorKit) => void} attest
*/

/**
Expand Down Expand Up @@ -102,7 +102,7 @@ export const prepareOperatorKit = (zone, staticPowers) =>
async submitEvidence(evidence) {
const { state } = this;
!state.disabled || Fail`submitEvidence for disabled operator`;
const result = state.powers.submitEvidence(evidence, this.facets);
const result = state.powers.attest(evidence, this.facets);
return result;
},
/** @returns {OperatorStatus} */
Expand Down
6 changes: 4 additions & 2 deletions packages/fast-usdc/src/exos/transaction-feed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const INVITATION_MAKERS_DESC = 'oracle operator invitation';

const TransactionFeedKitI = harden({
operatorPowers: M.interface('Transaction Feed Admin', {
submitEvidence: M.call(CctpTxEvidenceShape, M.any()).returns(),
attest: M.call(CctpTxEvidenceShape, M.any()).returns(),
}),
creator: M.interface('Transaction Feed Creator', {
// TODO narrow the return shape to OperatorKit
Expand Down Expand Up @@ -118,10 +118,12 @@ export const prepareTransactionFeedKit = (zone, zcf) => {
/**
* Add evidence from an operator.
*
* NB: the operatorKit is responsible for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for... what?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have gotten a Slack notification!

The operatorKit is responsible for preventing a disabled kit from attesting.

I'll get that in before merge. I'll probably wait for another reviewer's comments before pushing again.

*
* @param {CctpTxEvidence} evidence
* @param {OperatorKit} operatorKit
*/
submitEvidence(evidence, operatorKit) {
attest(evidence, operatorKit) {
const { pending } = this.state;
trace(
'submitEvidence',
Expand Down
2 changes: 1 addition & 1 deletion packages/fast-usdc/test/exos/transaction-feed.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ test.skip('forged source', async t => {

// op1 is different than the facets object the evidence must come from
t.throws(() =>
feedKit.operatorPowers.submitEvidence(
feedKit.operatorPowers.attest(
evidence,
// @ts-expect-error XXX Types of property '[GET_INTERFACE_GUARD]' are incompatible.
op1,
Expand Down