8606 invite proposals #10719
Open
8606 invite proposals #10719
+192
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correct one typeGuard Also noticed that the types documented for getProposalShapeForInvitation were incorrect. fixed that with Agoric/documentation#1258
Chris-Hibbert
force-pushed
the
8606-invite-proposals
branch
from
3a52442 to
cd810ec
Compare
Deploying agoric-sdk with
|
| Latest commit: |
f75a179
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ab3960b.agoric-sdk.pages.dev |
| Branch Preview URL: | https://8606-invite-proposals.agoric-sdk.pages.dev |
Chris-Hibbert
force-pushed
the
8606-invite-proposals
branch
from
cd810ec to
f75a179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8606
closes: #8597
Description
#8597 suggested adding a test proposal guards in Zoe. This adds that test, and also cleans up a redundant check in coveredCall. The added test exposed a mistake in the Zoe doc, so 1258 fixes that as well.
Security Considerations
None
Scaling Considerations
None.
Documentation Considerations
Improved documentation.
Testing Considerations
Added tests.
Upgrade Considerations
These changes do not impact code on-chain. There's a correction to an example contract, an improvement in a TypeGuard, and a documentation update which will be separately release.