test: add proposal w/300 E(chainTimerService).getTimerBrand() calls #10696
Conversation
Chris-Hibbert
added
force:integration
There was a problem hiding this comment.
I'm no expert on our proposal environment, but that looks good to me.
I'm guessing that this is safe to merge onto master because it lacks some glue that would include it in any particular upgrade proposal? And that whoever does the mainfork upgrade step (@toliaqat ?) will need to write that glue (and not check it in)?
It might benefit from a comment at the beginning to warn future readers against including this in a real proposal. The consequences would be minor (just some extra work, no lasting state), but still best to make it clear that this is for a specific testing exercise.
Correct, and I put it in a
If the mainfork upgrade allows including proposals (via
Okay, I'll add more. I intended the |
Deploying agoric-sdk with
|
| Latest commit: |
1184dad
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a66be3b1.agoric-sdk.pages.dev |
| Branch Preview URL: | https://cth-load-boyd.agoric-sdk.pages.dev |
…10696) ## Description @warner asked for a proposal that would ensure there were several more (300 was settled on) arbitrary calls in order to provoke bring-out-your-dead. ### Security Considerations test environments only: aimed at mainFork. ### Scaling Considerations No implications ### Documentation Considerations Unnecessary ### Testing Considerations For test environments. ### Upgrade Considerations None.
### Description Cherry-picks the following commits from master: - #10696 (3e27c74) - #10694 (140c1be) - #10704 (ab3fcb5, c025cb7) No new upgrade name has been added. Using following rebase todo: ``` # PR #10704 Branch build-deps-use-backport-of-cosmos-sdk-v0-46-15-10704- label onto pick 140c1be Save the contractKit for the auctioneer before overwriting it (#10694) pick 3e27c74 test: add proposal w/300 E(chainTimerService).getTimerBrand() calls (#10696) label base-build-deps-use-backport-of-cosmos-sdk-v0-46-15-10704- pick ab3fcb5 build(deps): use backport of cosmos-sdk v0.46.15 pick c025cb7 fix(cosmic-swingset): expect chain --halt-height exit status > 1 label pr-10704--build-deps-use-backport-of-cosmos-sdk-v0-46-15-10704- reset base-build-deps-use-backport-of-cosmos-sdk-v0-46-15-10704- # test: add proposal w/300 E(chainTimerService).getTimerBrand() calls (#10696) merge -C 5939b2a pr-10704--build-deps-use-backport-of-cosmos-sdk-v0-46-15-10704- # build(deps): use backport of cosmos-sdk v0.46.15 (#10704) ```
Description
@warner asked for a proposal that would ensure there were several more (300 was settled on) arbitrary calls in order to provoke bring-out-your-dead.
Security Considerations
test environments only: aimed at mainFork.
Scaling Considerations
No implications
Documentation Considerations
Unnecessary
Testing Considerations
For test environments.
Upgrade Considerations
None.