chore: fusdc ChainPolicy schema
#10679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
8955990
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://40318615.agoric-sdk.pages.dev |
| Branch Preview URL: | https://pc-chain-policy-schema.agoric-sdk.pages.dev |
0xpatrickdev
force-pushed
the
pc/chain-policy-schema
branch
from
db22887 to
48171d8
Compare
turadg
approved these changes
Dec 11, 2024
| @@ -58,11 +58,14 @@ export interface PoolMetrics extends PoolStats { | |||
| } | |||
|
|
|||
| export interface ChainPolicy { | |||
| nobleContractAddress: EvmHash; | |||
| /** `msg.sender` of DepositAndBurn to TokenMessenger must be an attenuated wrapper contract that does not contain `replaceDepositForBurn` */ | |||
There was a problem hiding this comment.
I'd like to see a few words from this JSDoc lifed to the PR description and/or title.
not critical.
samsiegart
reviewed
Dec 11, 2024
| confirmations: M.number(), | ||
| chainId: M.number(), | ||
| }, | ||
| { chainType: M.number() }, |
| @@ -17,10 +17,10 @@ Generated by [AVA](https://avajs.dev). | |||
| { | |||
| chainPolicies: { | |||
| Arbitrum: { | |||
| attenuatedCttpBridgeAddress: '0xe298b93ffB5eA1FB628e0C0D55A43aeaC268e347', | |||
There was a problem hiding this comment.
This address is different than the previous nobleContractAddress, should we update it in multichain-testing/test/fast-usdc/config.ts as well?
There was a problem hiding this comment.
Good catch I am basing this on top of master (instead), but I'll make sure to make this change there too
dckc
reviewed
Dec 11, 2024
| @@ -68,7 +68,8 @@ export const configurations = { | |||
| '0x19330d10D9Cc8751218eaf51E8885D058642E08A', | |||
| chainId: 42161, | |||
| confirmations: 2, | |||
| nobleContractAddress: '0x19330d10D9Cc8751218eaf51E8885D058642E08A', | |||
| attenuatedCttpBridgeAddress: | |||
| '0xe298b93ffB5eA1FB628e0C0D55A43aeaC268e347', | |||
There was a problem hiding this comment.
were these properties previously sorted?
| @@ -58,11 +58,14 @@ export interface PoolMetrics extends PoolStats { | |||
| } | |||
|
|
|||
| export interface ChainPolicy { | |||
| nobleContractAddress: EvmHash; | |||
| /** `msg.sender` of DepositAndBurn to TokenMessenger must be an attenuated wrapper contract that does not contain `replaceDepositForBurn` */ | |||
There was a problem hiding this comment.
I'd like to see a few words from this JSDoc lifed to the PR description and/or title.
not critical.
0xpatrickdev
force-pushed
the
pc/fusdc-multichain
branch
2 times, most recently
from
4ed677f to
d99ae45
Compare
0xpatrickdev
force-pushed
the
pc/chain-policy-schema
branch
from
48171d8 to
f046f07
Compare
|
Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label. |
- rename `nobleContractAddress` to `attenuatedCttpBridgeAddress` - include jsdoc comments for `ChainPolicy` type - removed `chainType` from `ChainPolicy`. unused and should have been an enum. not needed for OCW currently
0xpatrickdev
force-pushed
the
pc/chain-policy-schema
branch
from
f046f07 to
8955990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nobleContractAddresstoattenuatedCttpBridgeAddressas it better captures the functionality in FUSDC.replaceDepositForBurn. The Oracle Nodes must only report transactions wheredepositorforDepositForBurnis this value.ChainPolicytypeSecurity Considerations
None
Scaling Considerations
None
Documentation Considerations
Improves docs via jsdoc annotations
Testing Considerations
None
Upgrade Considerations
None, unreleased code