chore: uprade 18 cherrypicks round 5 #10676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: #10357 ## Description I did a bad copy paste in #10357, which causes the `run.id` of `timer-poll` triggers to all end up with the value `timer-poll-undefined`. Use the blockHeight instead. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations None ### Testing Considerations Not tested ### Upgrade Considerations Would be nice to pick in u18-rc4
Deploying agoric-sdk with
|
| Latest commit: |
d632323
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7698a271.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mk-u18-rc4-cherrypicks.agoric-sdk.pages.dev |
mhofman
approved these changes
Dec 11, 2024
|
still waiting on #10680. |
closes: #10669 ## Description Record instances of contracts that will be replaced so we can find them later and be able to manage them. ### Security Considerations We've lost the handle to some vats before, and it's a hassle. ### Scaling Considerations The problem gets worse as we upgrade more vats. ### Documentation Considerations None. ### Testing Considerations Verified that Auctions and Committee are present. The priceFeeds vary too much across test environments to be worth checking. ### Upgrade Considerations Yes..
mujahidkay
added
force:integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picks the following commits from master:
No new upgrade name has been added.
Done partially via git cherry-pick and via the following rebase-todo: