fix(z:acceptance): fix flakey z:acceptance/vaults.test.js
#10643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilhelvaci
requested review from
AgoricTriage,
0xpatrickdev and
Chris-Hibbert
anilhelvaci
force-pushed
the
anil/10599-fix-flakey
branch
from
6e9be33 to
40545af
Compare
Deploying agoric-sdk with
|
| Latest commit: |
82447f3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c19ab033.agoric-sdk.pages.dev |
| Branch Preview URL: | https://anil-10599-fix-flakey.agoric-sdk.pages.dev |
closes: #10599 fix: remove TODO comment fix: format fix
anilhelvaci
force-pushed
the
anil/10599-fix-flakey
branch
from
40545af to
82447f3
Compare
+1, nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10599
Description
#10599 pointed out a flakiness in
z:acceptance/vaults.test.js. Investigations showed the problem was because of the batched IST fee which is charged for every 10 offers for a given user. We started usingtryISTBalanceinstead of a direct assertion.Security Considerations
None.
Scaling Considerations
Making sure there are no flakiness in
a3p-integration/z:acceptancetests is important as it affects other PRs in the CI. This should fix one of the discovered ones.Documentation Considerations
None.
Testing Considerations
This should unblock other PRs CI process. No other considerations.
Upgrade Considerations
z:acceptancetests run before every upgrade.