fix(telemetry): Empty context persisted when remaining beans are negative after run finish #10635

usmanmani1122 · 2024-12-06T05:34:55Z

Description

Due to a faulty condition, empty context was persisted in case remaining beans were negative after a run finish
This PR also renames timestamp to time in the context-aware-slog-file.js slogger so that the timestamp is automatically picked up by GCP Stack driver as the time of the log

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

None

Upgrade Considerations

None

mhofman

Conditionally approved given we reorder fields for easier human consumption.

mhofman · 2024-12-06T11:41:01Z

packages/telemetry/src/context-aware-slog.js

@@ -356,7 +356,11 @@ export const makeContextualSlogProcessor = (
      // eslint-disable-next-line no-restricted-syntax
      case SLOG_TYPES.COSMIC_SWINGSET.RUN.FINISH: {
        assert(!!triggerContext);
-        persistContext(finalBody.remainingBeans ? {} : triggerContext);
+        persistContext(
+          finalBody.remainingBeans && finalBody.remainingBeans > 0


I sometimes dislike what types force us to do. The finalBody.remainingBeans && part is totally unnecessary at runtime.

mhofman · 2024-12-06T11:43:13Z

packages/telemetry/src/context-aware-slog-file.js


    // eslint-disable-next-line prefer-template
-    stream.write(serializeSlogObj(contextualizedSlog) + '\n').catch(() => {});
+    stream.write(serializeSlogObj({ time, ...rest }) + '\n').catch(() => {});


I would to keep the order or these fields sane when a human (me) is reading the file in a terminal or editor with no line wrap.

Suggested change

stream.write(serializeSlogObj({ time, ...rest }) + '\n').catch(() => {});

stream.write(serializeSlogObj({ ...rest, time }) + '\n').catch(() => {});

I kinda wish the process.uptime moved to the end of the attributes too.

Similarly let's move the body before attributes in the processor. Btw why not rename the time field there instead of here? We already have to extract and process it in the otel sender, so there's no extra work there, and we'd avoid extra work here.

I have moved process.uptime to the end, but GCP still order the keys
Same with attributes and body

Yup but at least the file output is maintaining the order.

cloudflare-workers-and-pages · 2024-12-06T12:21:55Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`5eff6ba`
Status:	✅ Deploy successful!
Preview URL:	https://5f867ff6.agoric-sdk.pages.dev
Branch Preview URL:	https://usman-misc-slogger-fixes.agoric-sdk.pages.dev

View logs

mergify · 2024-12-06T13:21:23Z

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #10635 has been dequeued. The pull request has been merged manually. The pull request has been merged manually at ad4e83e.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

…tive after run finish (#10635)

### Description Cherry-picks the following commits from master: - #10551 (9e19321) - #10635 (ad4e83e) - #10615 (e596a01 ) - #10634 (a1856f3) Since we plan to verify this rc on devnet rather than emerynet, there is no apparent need for a new upgrade name. Not aware of any deployments on devnet before so can reuse the previous upgrade name. However, skipping emerynet is dependent on comms with the validators so I have added a new upgrade name `agoric-ugprade-18-emerynet-rc3` just in case. Only added to bypass the need for a new rc if for some reason emerynet validation is needed anyways - best case scenario is that it remains unused. commits added using git cherry-pick

## Description Created as per MAINTAINERS.md ## Changes - @agoric/[email protected] - [email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - [email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] ## Packages that have NEWS.md updates ```diff --- a/packages/telemetry/CHANGELOG.md +++ b/packages/telemetry/CHANGELOG.md @@ -3,6 +3,16 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +### [0.6.3-u18.2](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-09) + + +### Bug Fixes + +* **telemetry:** Empty context persisted when remaining beans are negative after run finish ([#10635](#10635)) ([3988aa0](3988aa0)) +* **telemetry:** event name typo ([070b154](070b154)) + + + ### [0.6.3-u18.1](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-11-19) ```

## Description Created as per instructions in MAINTAINERS.md. Includes an additional step to update yarn.lock for multichain-testing, a3p-integration/proposals/s:stake-bld and a3p-integration/proposals/z:acceptance ## Changes - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - [email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] ## Packages that have NEWS.md updates ```diff --- a/golang/cosmos/CHANGELOG.md +++ b/golang/cosmos/CHANGELOG.md @@ -3,6 +3,32 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.35.0-u18.5](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Features + +* **cosmos:** Support arbitrary core eval builder arguments ([#10767](#10767)) ([a944f4c](a944f4c)), closes [#10752](#10752) [#10752](#10752) +* **cosmos:** use `x/vbank` ConsensusVersion to upgrade monitoring ([0e367d3](0e367d3)) +* migrate upgrade of v7-board from upgrade 19 to upgrade 18 ([#10761](#10761)) ([837776e](837776e)), closes [#10760](#10760) +* upgrade v7-board and test it ([#10516](#10516)) ([d8a109e](d8a109e)), closes [#10394](#10394) +* **vbank:** new param `allowed_monitoring_accounts` ([5ac4c52](5ac4c52)) +* **vtransfer:** extract base address from parameterized address ([3d44b53](3d44b53)) +* **vtransfer:** port some `address-hooks.js` functions to Go ([159098b](159098b)) +* **x/swingset:** Add parameters for controlling vat cleanup budget ([02c8138](02c8138)), closes [#8928](#8928) +* **x/swingset:** Define default vat cleanup budget as { default: 5, kv: 50 } ([d86ee6d](d86ee6d)) +* **x/swingset:** Read beansPerUnit in each message handler and pass down to helpers ([55b9b49](55b9b49)) +* **x/swingset:** Require a non-empty vat cleanup budget to include `default` ([28c4d8b](28c4d8b)) + + +### Bug Fixes + +* **agd:** upgrade all orchestration vats to new liveslots ([59fa82c](59fa82c)) +* **cosmos:** return an error if version is unsupported ([d17e55b](d17e55b)) +* **x/swingset:** Let migration see incomplete Params structs ([315cdd5](315cdd5)) + + + ## [0.35.0-u18.4](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-17) **Note:** Version bump only for package @agoric/cosmos --- a/packages/ERTP/CHANGELOG.md +++ b/packages/ERTP/CHANGELOG.md @@ -3,6 +3,16 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +### [0.16.3-u18.1](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Bug Fixes + +* **ertp:** remove unneeded ertp type imports ([#10467](#10467)) ([e96ff82](e96ff82)), closes [#10456](#10456) +* **orchestration:** harden exported patterns ([#10470](#10470)) ([47bebb8](47bebb8)), closes [#10456](#10456) + + + ### [0.16.3-u18.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-10-31) --- a/packages/SwingSet/CHANGELOG.md +++ b/packages/SwingSet/CHANGELOG.md @@ -3,6 +3,21 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.33.0-u18.1](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Features + +* **internal:** Introduce deepCopyJsonable ([f875bb0](f875bb0)) + + +### Bug Fixes + +* **orchestration:** harden exported patterns ([#10470](#10470)) ([47bebb8](47bebb8)), closes [#10456](#10456) +* **SwingSet:** Introduce a termination-dedicated "VatUndertaker" analog to "VatKeeper" ([b786414](b786414)) + + + ## [0.33.0-u18.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-10-31) --- a/packages/agoric-cli/CHANGELOG.md +++ b/packages/agoric-cli/CHANGELOG.md @@ -3,6 +3,37 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.22.0-u18.6](https://github.com/Agoric/agoric-sdk/compare/[email protected]@0.22.0-u18.6) (2024-12-24) + + +### ⚠ BREAKING CHANGES + +* remove agoricNames from VstorageKit + +### Features + +* **agoric-cli:** Add `agoric wallet send` gas limit options ([21a03f8](21a03f8)) +* **agoric-cli:** Block `agoric wallet send` on tx inclusion ([0389a21](0389a21)) +* client-utils package ([50af71f](50af71f)) +* export cli lib ([0d2d4aa](0d2d4aa)) +* fetchEnvNetworkConfig ([9bdba57](9bdba57)) +* makeWalletUtils wo/spawn ([bc10509](bc10509)) +* makeWalletUtils wo/spawn ([20083ae](20083ae)) +* VstorageKit ([71486d7](71486d7)) + + +### Bug Fixes + +* **agoric-cli:** use readPublished consistently in agops oracle ([e8f6de2](e8f6de2)) +* proposeParamChange options ([202ba1e](202ba1e)) + + +### Miscellaneous Chores + +* remove agoricNames from VstorageKit ([1c69d39](1c69d39)) + + + ## [0.22.0-u18.5](https://github.com/Agoric/agoric-sdk/compare/[email protected]@0.22.0-u18.5) (2024-12-17) **Note:** Version bump only for package agoric --- a/packages/boot/CHANGELOG.md +++ b/packages/boot/CHANGELOG.md @@ -3,6 +3,27 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.2.0-u18.6](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Features + +* add `bech32Prefix?: string` to `CosmosChainInfo` ([cb9e1ee](cb9e1ee)) +* consistent publishTxnRecord (record) ([dbf3934](dbf3934)) +* **fast-usdc:** publish feeConfig to vstorage ([08b2e13](08b2e13)) +* **fast-usdc:** support risk assessment arg ([ff6737a](ff6737a)) +* **fast-usdc:** write chain policies to vstorage ([#10532](#10532)) ([9d6cff1](9d6cff1)) +* **fast-usdc:** write status updates to vstorage ([#10552](#10552)) ([419df4e](419df4e)) +* **internal:** Introduce deepCopyJsonable ([f875bb0](f875bb0)) +* publish OBSERVED with first evidence ([7e62d8f](7e62d8f)) +* readPublished in SwingsetTestKit ([0b383c9](0b383c9)) +* record instances that will be replaced so we can manage them ([c883c39](c883c39)) +* send-anywhere inits chainHub ([2fa2f75](2fa2f75)) +* **types:** TransactionRecord ([ccb9e28](ccb9e28)) +* vstorage status --> txns ([aebb4d7](aebb4d7)) + + + ## [0.2.0-u18.5](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-17) **Note:** Version bump only for package @agoric/boot --- a/packages/builders/CHANGELOG.md +++ b/packages/builders/CHANGELOG.md @@ -3,6 +3,41 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.2.0-u18.6](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Features + +* `ForwardOpts` accepts `intermediateRecipient` ([eb975f1](eb975f1)) +* `ForwardOptsShape` ([50b1717](50b1717)) +* add `bech32Prefix?: string` to `CosmosChainInfo` ([cb9e1ee](cb9e1ee)) +* advancer with fees ([087f3a8](087f3a8)) +* assetInfo as array of entries ([51e7a9c](51e7a9c)) +* **builders:** --noNoble option for init-fast-usdc ([508a3e0](508a3e0)) +* **builders:** fast-usdc builder w/CLI config ([9f45a05](9f45a05)) +* **builders:** fast-usdc oracleSet option for MAINNET, ... ([3bf01a2](3bf01a2)) +* **builders:** fast-usdc policy update builder ([8ded3d8](8ded3d8)) +* chain-capabilities.js constants ([52ff70a](52ff70a)) +* export `DenomDetailShape` ([2dfddb3](2dfddb3)) +* export `OrchestrationPowersShape` ([34b61ea](34b61ea)) +* **fast-usdc:** write chain policies to vstorage ([#10532](#10532)) ([9d6cff1](9d6cff1)) +* fusdc assetInfo and chainInfo by netname ([afb4f34](afb4f34)) +* parameterize fusdc with chainInfo and assetInfo ([e5a8b64](e5a8b64)) +* record instances that will be replaced so we can manage them ([c883c39](c883c39)) +* register interchain bank assets proposal ([0e20707](0e20707)) +* registerChainsAndAssets ([e72782d](e72782d)) +* save the outgoing EC Charter instance and kit ([c2c9be3](c2c9be3)) +* send-anywhere inits chainHub ([2fa2f75](2fa2f75)) +* upgrade v7-board and test it ([#10516](#10516)) ([d8a109e](d8a109e)), closes [#10394](#10394) + + +### Bug Fixes + +* **agd:** upgrade all orchestration vats to new liveslots ([59fa82c](59fa82c)) +* **orchestration:** denomAmounts must be non-negative ([#10458](#10458)) ([40e0e4e](40e0e4e)) + + + ## [0.2.0-u18.5](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-17) **Note:** Version bump only for package @agoric/builders --- a/packages/casting/CHANGELOG.md +++ b/packages/casting/CHANGELOG.md @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +### [0.4.3-u18.5](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Features + +* makeTendermintRpcClient ([129516a](129516a)) + + + ### [0.4.3-u18.4](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-17) **Note:** Version bump only for package @agoric/casting --- a/packages/client-utils/CHANGELOG.md +++ b/packages/client-utils/CHANGELOG.md @@ -1 +1,41 @@ +# Change Log + +All notable changes to this project will be documented in this file. +See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. + +## 0.2.0-u18.0 (2024-12-24) + + +### ⚠ BREAKING CHANGES + +* remove agoricNames from VstorageKit + +### Features + +* client-utils package ([50af71f](50af71f)) +* export makeStargateClient ([186d268](186d268)) +* fetchEnvNetworkConfig ([9bdba57](9bdba57)) +* getCurrentWalletRecord ([2740748](2740748)) +* makeWalletUtils wo/spawn ([20083ae](20083ae)) +* ocap makeStargateClient ([c8f7407](c8f7407)) +* one marshaller per WalletUtils ([b141ce6](b141ce6)) +* **sync-tools:** add method to wait until offer exited ([c9370f2](c9370f2)) +* **types:** TypedPublished ([88939bf](88939bf)) +* vstorage without instance binding ([2c4e2e3](2c4e2e3)) +* VstorageKit ([71486d7](71486d7)) +* VstorageKit readPublished ([e48c53c](e48c53c)) + + +### Bug Fixes + +* **client-utils:** only call `fetch` as a function, not a method ([#10671](#10671)) ([fbae24c](fbae24c)), closes [/github.com/endojs/endo/issues/31#issuecomment-1255624116](https://github.com/Agoric//github.com/endojs/endo/issues/31/issues/issuecomment-1255624116) +* **client-utils:** Retry at least every other interval ([fd9394b](fd9394b)) + + +### Miscellaneous Chores + +* remove agoricNames from VstorageKit ([1c69d39](1c69d39)) + + + # Change Log --- a/packages/cosmic-proto/CHANGELOG.md +++ b/packages/cosmic-proto/CHANGELOG.md @@ -3,6 +3,21 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.5.0-u18.5](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Features + +* **vats:** first cut of Address Hooks in JS ([dbad30b](dbad30b)) + + +### Bug Fixes + +* **address-hooks:** throw if the version is unsupported ([e3c2665](e3c2665)) +* **address-hooks:** use `harden` (or `freeze`) ([80fee60](80fee60)) + + + ## [0.5.0-u18.4](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-17) **Note:** Version bump only for package @agoric/cosmic-proto --- a/packages/cosmic-swingset/CHANGELOG.md +++ b/packages/cosmic-swingset/CHANGELOG.md @@ -3,6 +3,25 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.42.0-u18.6](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Features + +* **cosmic-swingset:** Add support for testing blocks of a mock chain ([48b6405](48b6405)) +* **cosmic-swingset:** Allow `launch` to accept an already-open swingStore ([c65e5b1](c65e5b1)) +* **cosmic-swingset:** Update parseParams to read and validate vat cleanup budget data ([80bcca0](80bcca0)), closes [#8928](#8928) +* **cosmic-swingset:** Use vat cleanup budget values to allow slow cleanup ([508ea8e](508ea8e)), closes [#8928](#8928) +* **internal:** Introduce deepCopyJsonable ([f875bb0](f875bb0)) +* **x/swingset:** Define default vat cleanup budget as { default: 5, kv: 50 } ([d86ee6d](d86ee6d)) + + +### Bug Fixes + +* **cosmic-swingset:** expect chain --halt-height exit status > 1 ([c025cb7](c025cb7)) + + + ## [0.42.0-u18.5](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-17) --- a/packages/fast-usdc/CHANGELOG.md +++ b/packages/fast-usdc/CHANGELOG.md @@ -3,6 +3,128 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## 0.2.0-u18.0 (2024-12-24) + + +### Features + +* error on conflicting evidence ([cd2a40c](cd2a40c)) +* **fast-usdc:** add FastLP/ufastlp to vbank ([ae1963e](ae1963e)) +* **fast-usdc:** detect transfer completion in cli ([2828444](2828444)) +* **fast-usdc:** support risk assessment arg ([ff6737a](ff6737a)) +* operator majority logic ([bc28201](bc28201)) +* record fee split in transaction ([8846972](8846972)) + +## 0.35.0-u18.4 (2024-12-17) + + +### ⚠ BREAKING CHANGES + +* remove agoricNames from VstorageKit + +### Features + +* consistent publishTxnRecord (record) ([dbf3934](dbf3934)) +* deleteCompletedTxs ([f0078ee](f0078ee)) +* **fast-usdc:** cli for lp deposit and withdraw ([4c0c372](4c0c372)) +* **fast-usdc:** limited operation before connecting to noble ([eb82ae3](eb82ae3)) +* include 'sender' in CctpTxEvidence ([f99e7b8](f99e7b8)) +* publish CctpTxEvidence ([2916c8f](2916c8f)) +* publish OBSERVED with first evidence ([7e62d8f](7e62d8f)) +* simplify seenTxs key ([fd05a7e](fd05a7e)) +* **types:** TransactionRecord ([ccb9e28](ccb9e28)) +* vstorage status --> txns ([aebb4d7](aebb4d7)) + + +### Bug Fixes + +* do not stringify logs ([d04c5ea](d04c5ea)) +* vstorage fastUsdc path ([1f47164](1f47164)) + + +### Miscellaneous Chores + +* remove agoricNames from VstorageKit ([1c69d39](1c69d39)) + +## 0.35.0-u18.3 (2024-12-09) + + +### ⚠ BREAKING CHANGES + +* `getAsset` and `getDenomInfo` require `srcChainName` param + +### Features + +* `getAsset` and `getDenomInfo` require `srcChainName` param ([fc802ad](fc802ad)) +* assetInfo as array of entries ([51e7a9c](51e7a9c)) +* **fast-usdc:** core-eval to update feed policy ([db283e1](db283e1)) +* **fast-usdc:** operator attest cli command ([448aa3a](448aa3a)) +* **fast-usdc:** publish feeConfig to vstorage ([08b2e13](08b2e13)) +* **fast-usdc:** settler disburses or forwards funds ([17b0423](17b0423)) +* **fast-usdc:** write chain policies to vstorage ([#10532](#10532)) ([9d6cff1](9d6cff1)) +* **fast-usdc:** write status updates to vstorage ([#10552](#10552)) ([419df4e](419df4e)) +* operator accept cmd ([ae2cf1e](ae2cf1e)) +* parameterize fusdc with chainInfo and assetInfo ([e5a8b64](e5a8b64)) +* scaffold operator commands ([36375fd](36375fd)) + + +### Bug Fixes + +* `brandKey` not part of `DenomDetail` ([9a65478](9a65478)) + +## 0.35.0-u18.2 (2024-11-21) + + +### Features + +* `Advancer` uses `borrower` facet ([35eb7ad](35eb7ad)) +* integrate `Advancer` with contract ([c5d67af](c5d67af)) +* liquidity pool borrower and repayer facets ([3117eef](3117eef)) + +## 0.35.0-u18.1 (2024-11-19) + + +### Features + +* `Advancer` exo behaviors ([4cd2f3f](4cd2f3f)), closes [#10390](#10390) +* `CctpTxEvidenceShape`, `PendingTxShape` typeGuards ([5a7b3d2](5a7b3d2)) +* `getQueryParams` takes shape parameter ([99707ef](99707ef)) +* `StatusManager` scaffold ([980463f](980463f)) +* `StatusManager` tracks `seenTxs` ([f3d1e36](f3d1e36)) +* `TxStatus` const for `StatusManager` states ([1376020](1376020)) +* advancer with fees ([087f3a8](087f3a8)) +* defineInertInvitation ([f756412](f756412)) +* **fast-usdc:** .start.js core-eval w/oracle invitations ([7b6820a](7b6820a)) +* **fast-usdc:** add cli config and args for deposit and withdraw ([#10487](#10487)) ([fb2d05c](fb2d05c)) +* **fast-usdc:** deposit, withdraw liquidity in exchange for shares ([5ae543d](5ae543d)) +* **fast-usdc:** implement config cli command ([d121e1d](d121e1d)) +* **fast-usdc:** implement transfer cli command ([504818f](504818f)) +* **fast-usdc:** stub config cli command ([81e14b2](81e14b2)) +* **fast-usdc:** stub transfer cli command ([1b64d82](1b64d82)) +* feed access controls ([8f4a66d](8f4a66d)) +* makeTestPushInvitation handles evidence ([7e99cfa](7e99cfa)) +* minimal `addressTools` for query param parsing ([6f97e13](6f97e13)) +* operators evidence flows through feed ([2161a6f](2161a6f)) +* publish when all oracle operators agree ([d06ae2b](d06ae2b)) +* TransactionFeedKit ([8eb7dee](8eb7dee)) +* uniform configuration with LegibleCapData ([968903a](968903a)) + + +### Bug Fixes + +* **fast-usdc:** ensure cli non-zero exit code on failure ([6c0e77b](6c0e77b)) +* **fast-usdc:** fix url encoding ([d46cefd](d46cefd)) +* **fast-usdc:** use correct address format in cli ([d225974](d225974)) + +## 0.35.0-u18.0 (2024-10-31) + + +### Features + +* add CLI for fast-usdc package ([92bc5b1](92bc5b1)) + + + ### [0.1.1-u18.5](https://github.com/Agoric/agoric-sdk/compare/[email protected]@0.1.1-u18.5) (2024-12-17) **Note:** Version bump only for package fast-usdc --- a/packages/governance/CHANGELOG.md +++ b/packages/governance/CHANGELOG.md @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +### [0.10.4-u18.1](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Bug Fixes + +* **orchestration:** harden exported patterns ([#10470](#10470)) ([47bebb8](47bebb8)), closes [#10456](#10456) + + + ### [0.10.4-u18.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-10-31) --- a/packages/inter-protocol/CHANGELOG.md +++ b/packages/inter-protocol/CHANGELOG.md @@ -3,6 +3,23 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.17.0-u18.6](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Features + +* add an accessor for the vaultDirector's parameters ([32f1398](32f1398)) +* record instances that will be replaced so we can manage them ([c883c39](c883c39)) +* save the outgoing EC Charter instance and kit ([c2c9be3](c2c9be3)) + + +### Bug Fixes + +* makeReserveTerms ([27ce0b0](27ce0b0)) +* remove addInstance call from add-auction.js ([d16781f](d16781f)) + + + ## [0.17.0-u18.5](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-17) **Note:** Version bump only for package @agoric/inter-protocol --- a/packages/internal/CHANGELOG.md +++ b/packages/internal/CHANGELOG.md @@ -3,6 +3,21 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.4.0-u18.1](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Features + +* consistent publishTxnRecord (record) ([dbf3934](dbf3934)) +* defaultSerializer util ([19d5e03](19d5e03)) +* getValues for sequence nodes ([b5698ce](b5698ce)) +* **internal:** Introduce deepCopyJsonable ([f875bb0](f875bb0)) +* pureDataMarshaller ([6df7f1f](6df7f1f)) +* showValue option for documentStorageSchema ([07d12d4](07d12d4)) +* storage-test-utils report missing data ([02c111b](02c111b)) + + + ## [0.4.0-u18.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-10-31) --- a/packages/orchestration/CHANGELOG.md +++ b/packages/orchestration/CHANGELOG.md @@ -3,6 +3,48 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.2.0-u18.5](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### ⚠ BREAKING CHANGES + +* `getAsset` and `getDenomInfo` require `srcChainName` param + +### Features + +* `assetOn` `DenomDetail` helper ([05fe515](05fe515)) +* `chainHub.makeTransferRoute` ([0215b6f](0215b6f)) +* `ForwardOpts` accepts `intermediateRecipient` ([eb975f1](eb975f1)) +* `ForwardOptsShape` ([50b1717](50b1717)) +* `getAsset` and `getDenomInfo` require `srcChainName` param ([fc802ad](fc802ad)) +* `withOrchestration` returns `baggage` ([e4a6c6d](e4a6c6d)) +* add `bech32Prefix?: string` to `CosmosChainInfo` ([cb9e1ee](cb9e1ee)) +* assetInfo as array of entries ([51e7a9c](51e7a9c)) +* chain-capabilities.js constants ([52ff70a](52ff70a)) +* **chainHub:** `getChainInfoByAddress` helper ([d6c487c](d6c487c)) +* **cosmos-orch-account:** expose `.executeEncodedTx` ([9d10be1](9d10be1)) +* CosmosChainInfo includes `pfmEnabled?: boolean` ([e1c35da](e1c35da)) +* export `DenomDetailShape` ([2dfddb3](2dfddb3)) +* export `OrchestrationPowersShape` ([34b61ea](34b61ea)) +* **local-orchestration-account:** support multi-hop pfm transfers ([c35fac7](c35fac7)) +* registerChainsAndAssets ([e72782d](e72782d)) +* send-anywhere inits chainHub ([2fa2f75](2fa2f75)) + + +### Bug Fixes + +* `brandKey` not part of `DenomDetail` ([9a65478](9a65478)) +* `convertChainInfo` connection sorting ([8ba4699](8ba4699)) +* do not stringify logs ([d04c5ea](d04c5ea)) +* **orchestration:** denomAmounts must be non-negative ([#10458](#10458)) ([40e0e4e](40e0e4e)) +* **orchestration:** harden exported patterns ([#10470](#10470)) ([47bebb8](47bebb8)), closes [#10456](#10456) +* **orchestration:** harden result of reverseConnInfo ([5c1219c](5c1219c)) +* subscribeToTransfers atomically ([7b77993](7b77993)) +* use `asVow` in case `owned()` throws ([e67e86b](e67e86b)) +* yarn codegen script ([9eea3fd](9eea3fd)) + + + ## [0.2.0-u18.4](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-17) **Note:** Version bump only for package @agoric/orchestration --- a/packages/solo/CHANGELOG.md +++ b/packages/solo/CHANGELOG.md @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.11.0-u18.6](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Features + +* **internal:** Introduce deepCopyJsonable ([f875bb0](f875bb0)) + + + ## [0.11.0-u18.5](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-17) **Note:** Version bump only for package @agoric/solo --- a/packages/swing-store/CHANGELOG.md +++ b/packages/swing-store/CHANGELOG.md @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.10.0-u18.1](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Features + +* **cosmic-swingset:** Allow `launch` to accept an already-open swingStore ([c65e5b1](c65e5b1)) + + + ## [0.10.0-u18.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-10-31) --- a/packages/swingset-liveslots/CHANGELOG.md +++ b/packages/swingset-liveslots/CHANGELOG.md @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +### [0.10.3-u18.1](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Bug Fixes + +* **liveslots:** avoid slotToVal memory leak for watched promises ([874196c](874196c)), closes [#10757](#10757) [#10756](#10756) [#10706](#10706) + + + ### [0.10.3-u18.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-10-31) --- a/packages/telemetry/CHANGELOG.md +++ b/packages/telemetry/CHANGELOG.md @@ -3,6 +3,18 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +### [0.6.3-u18.4](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Bug Fixes + +* **telemetry:** add missing slog type ([1aec8d0](1aec8d0)) +* **telemetry:** Empty context persisted when remaining beans are negative after run finish ([#10635](#10635)) ([ad4e83e](ad4e83e)) +* **telemetry:** event name typo ([9e19321](9e19321)) +* **telemetry:** timer-poll run.id ([#10672](#10672)) ([3b478fb](3b478fb)), closes [#10357](#10357) [#10357](#10357) + + + ### [0.6.3-u18.3](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-13) --- a/packages/time/CHANGELOG.md +++ b/packages/time/CHANGELOG.md @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +### [0.3.3-u18.1](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Bug Fixes + +* **orchestration:** harden exported patterns ([#10470](#10470)) ([47bebb8](47bebb8)), closes [#10456](#10456) + + + ### [0.3.3-u18.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-10-31) --- a/packages/vats/CHANGELOG.md +++ b/packages/vats/CHANGELOG.md @@ -3,6 +3,22 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.16.0-u18.5](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Features + +* **cosmic-swingset:** Add support for testing blocks of a mock chain ([48b6405](48b6405)) +* upgrade v7-board and test it ([#10516](#10516)) ([d8a109e](d8a109e)), closes [#10394](#10394) + + +### Bug Fixes + +* **ERTP,vats:** fix 9407 AmountPatternShape ([#9863](#9863)) ([59b1a9f](59b1a9f)), closes [#9410](#9410) [#9407](#9407) [#9410](#9410) [#9407](#9407) [#9410](#9410) [#9407](#9407) [#9410](#9410) +* **vaultFactory:** fix proposal description ([bc1f87a](bc1f87a)) + + + ## [0.16.0-u18.4](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-17) **Note:** Version bump only for package @agoric/vats --- a/packages/wallet/CHANGELOG.md +++ b/packages/wallet/CHANGELOG.md @@ -3,6 +3,23 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.19.0-u18.1](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + +## 0.35.0-u18.4 (2024-12-17) + +## 0.35.0-u18.3 (2024-12-09) + +## 0.35.0-u18.2 (2024-11-21) + +## 0.35.0-u18.1 (2024-11-19) + + +### Features + +* **internal:** Introduce deepCopyJsonable ([f875bb0](f875bb0)) + + + ## [0.19.0-u18.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-10-31) --- a/packages/wallet/api/CHANGELOG.md +++ b/packages/wallet/api/CHANGELOG.md @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.15.0-u18.5](https://github.com/Agoric/agoric/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Features + +* **internal:** Introduce deepCopyJsonable ([f875bb0](f875bb0)) + + + ## [0.15.0-u18.4](https://github.com/Agoric/agoric/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-17) **Note:** Version bump only for package @agoric/wallet-backend --- a/packages/zoe/CHANGELOG.md +++ b/packages/zoe/CHANGELOG.md @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +### [0.26.3-u18.1](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-12-24) + + +### Bug Fixes + +* **orchestration:** harden exported patterns ([#10470](#10470)) ([47bebb8](47bebb8)), closes [#10456](#10456) + + + ### [0.26.3-u18.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2024-10-31) ```

fixes

0aaa4c6

usmanmani1122 requested a review from mhofman December 6, 2024 05:34

usmanmani1122 self-assigned this Dec 6, 2024

usmanmani1122 requested a review from a team as a code owner December 6, 2024 05:34

mhofman approved these changes Dec 6, 2024

View reviewed changes

ARC Matheiu

5eff6ba

mhofman approved these changes Dec 6, 2024

View reviewed changes

usmanmani1122 added the automerge:squash Automatically squash merge label Dec 6, 2024

usmanmani1122 merged commit ad4e83e into master Dec 6, 2024
88 of 90 checks passed

usmanmani1122 deleted the usman/misc-slogger-fixes branch December 6, 2024 13:20

mujahidkay pushed a commit that referenced this pull request Dec 9, 2024

fix(telemetry): Empty context persisted when remaining beans are nega…

3988aa0

…tive after run finish (#10635)

mujahidkay mentioned this pull request Dec 9, 2024

chore: upgrade 18 cherrypicks round 4 #10645

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(telemetry): Empty context persisted when remaining beans are negative after run finish #10635

fix(telemetry): Empty context persisted when remaining beans are negative after run finish #10635

usmanmani1122 commented Dec 6, 2024

mhofman left a comment

mhofman Dec 6, 2024

mhofman Dec 6, 2024

usmanmani1122 Dec 6, 2024

mhofman Dec 6, 2024

cloudflare-workers-and-pages bot commented Dec 6, 2024 •

edited

Loading

mergify bot commented Dec 6, 2024

	stream.write(serializeSlogObj({ time, ...rest }) + '\n').catch(() => {});
	stream.write(serializeSlogObj({ ...rest, time }) + '\n').catch(() => {});

fix(telemetry): Empty context persisted when remaining beans are negative after run finish #10635

fix(telemetry): Empty context persisted when remaining beans are negative after run finish #10635

Conversation

usmanmani1122 commented Dec 6, 2024

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

mhofman left a comment

Choose a reason for hiding this comment

mhofman Dec 6, 2024

Choose a reason for hiding this comment

mhofman Dec 6, 2024

Choose a reason for hiding this comment

usmanmani1122 Dec 6, 2024

Choose a reason for hiding this comment

mhofman Dec 6, 2024

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Dec 6, 2024 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

mergify bot commented Dec 6, 2024

cloudflare-workers-and-pages bot commented Dec 6, 2024 •

edited

Loading