chore(fast-usdc): prune testBorrow, testRepay methods #10607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Dec 3, 2024
| @@ -494,3 +494,29 @@ test('repay fails when seat allocation does not equal amounts', t => { | |||
| }, | |||
| ); | |||
| }); | |||
|
|
|||
| test('repay succeeds with no Pool or Contract Fee', t => { | |||
| const { USDC } = brands; | |||
There was a problem hiding this comment.
out of scope: consider using withAmountUtils to make the brands, issuers and amounts easier to work with
| totalBorrows: make(USDC, 100n), | ||
| }; | ||
| const fromSeatAllocation = amounts; | ||
| t.notThrows(() => |
There was a problem hiding this comment.
consider verifying the shareWorth doesn't change and encumberedBalance does.
Deploying agoric-sdk with
|
| Latest commit: |
d96a45e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://005c481a.agoric-sdk.pages.dev |
| Branch Preview URL: | https://dc-fc-contract-tests.agoric-sdk.pages.dev |
dckc
force-pushed
the
dc-fc-contract-tests
branch
from
fbfe008 to
a6b86da
Compare
samsiegart
approved these changes
Dec 3, 2024
dckc
force-pushed
the
dc-fc-contract-tests
branch
from
ffc0cbc to
78c2eab
Compare
- largely covered by share-pool-math tests
- move 'repay succeeds with no Pool or Contract Fee'
from contract test to pool-share-math test.
- borrow / repay are internal APIs with static types
- testing consistency between interface guards and static types
might have some value, but not enough
dckc
force-pushed
the
dc-fc-contract-tests
branch
from
78c2eab to
d96a45e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10388
refs: #10511
Description
Prune
testBorrow,testRepaymethods along with contract tests that depend on them.lp.borrower.borrow/lp.repayer.repay.These are internal APIs with static types.
might have some value, but, I suggest, not enough for the cost
Scaling / Documentation / Upgrade Considerations
none
Security / Testing Considerations
small loss in test coverage - mostly in test redundancy
makeTestPushInvitationremains on the public facet. Getting rid of it in due course remains critical.I expect / hope we can get rid of it in #10606 (cc @samsiegart ) .
Ideally, the liquidity-pool exo would have unit test coverage. I looked into that but found that I would have to build substantial ZCF / Zoe test tooling. Since
liquidity-pool.jsis just 360 lines of straightforward Zoe API usage, I suggest we postpone that under...