Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace tsx with ts-blank-space #10605

Merged
merged 7 commits into from
Dec 3, 2024
Merged

replace tsx with ts-blank-space #10605

merged 7 commits into from
Dec 3, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Dec 2, 2024

incidental

Description

Remove tsx now that we can use ts-blank-space throughout. It aligns better with future .ts support in Node.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

fewer cases, fewer deps

Testing Considerations

CI

Upgrade Considerations

none

@turadg turadg requested a review from a team as a code owner December 2, 2024 21:56
Copy link

cloudflare-workers-and-pages bot commented Dec 2, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: ecd8939
Status: ✅  Deploy successful!
Preview URL: https://5d403c17.agoric-sdk.pages.dev
Branch Preview URL: https://ta-no-tsx.agoric-sdk.pages.dev

View logs

@0xpatrickdev 0xpatrickdev added the force:integration Force integration tests to run on PR label Dec 2, 2024
@turadg turadg requested review from 0xpatrickdev and dckc December 3, 2024 00:08
@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Dec 3, 2024
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice.

@turadg turadg force-pushed the ta/no-tsx branch 2 times, most recently from 106e1a2 to 92a66af Compare December 3, 2024 18:23
@mergify mergify bot merged commit e37a322 into master Dec 3, 2024
81 checks passed
@mergify mergify bot deleted the ta/no-tsx branch December 3, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants