Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agoric-cli): wrong URL in agops oracle setPrice, find-continuing-id #10593

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

dckc
Copy link
Member

@dckc dckc commented Dec 2, 2024

refs:

Description

It looks like #10450 changed the URL used to get oracle operator wallet info from

https://emerynet.rpc.agoric.net:443/abci_query?path=%22/custom/vstorage/data/published.wallet.agoric1ldmtatp24qlllgxmrsjzcpe20fvlkp448zcuce.current%22&height=0

to

https://emerynet.rpc.agoric.net:443/abci_query?path=%22/custom/vstorage/data/wallet.agoric1ldmtatp24qlllgxmrsjzcpe20fvlkp448zcuce.current%22&height=0

This PR uses readPublished consistently in order to restore the published. prefix.

Security / Scaling / Documentation Considerations

none

Testing Considerations

I'm a little surprised that we don't have z:acceptance tests that rely on this testing tool.

Upgrade Considerations

This is client-side only code.

@dckc dckc requested a review from a team as a code owner December 2, 2024 04:32
@dckc dckc added the automerge:rebase Automatically rebase updates, then merge label Dec 2, 2024
@dckc
Copy link
Member Author

dckc commented Dec 2, 2024

I'm not sure what to make of this acceptance test error... flake?

    'Error: error in json rpc client, with http response metadata: (Status: 200 OK, Protocol HTTP/1.1). RPC error -32603 - Internal error: timed out waiting for tx to be included in a block\n' 

@mergify mergify bot merged commit 963ebe1 into master Dec 2, 2024
91 checks passed
@mergify mergify bot deleted the dckc-patch-1 branch December 2, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants