Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client utils vstorage without instance binding #10566

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

turadg
Copy link
Member

@turadg turadg commented Nov 25, 2024

closes: #10563

Description

It would help users of client-utils to be able to use VStorage methods as first-class functions. This removes using this as the namespace of the helper functions.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

none

Testing Considerations

New test (which failed before the change)

Upgrade Considerations

none

@turadg turadg requested a review from a team as a code owner November 25, 2024 19:41
Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 13656e5
Status: ✅  Deploy successful!
Preview URL: https://c1d88ef1.agoric-sdk.pages.dev
Branch Preview URL: https://10563-vsk-functions.agoric-sdk.pages.dev

View logs

Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. This looks cleaner to me.

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Nov 25, 2024
@turadg turadg force-pushed the 10563-vsk-functions branch from 599c251 to a4b0b36 Compare November 25, 2024 22:13
@turadg turadg force-pushed the 10563-vsk-functions branch from a4b0b36 to 13656e5 Compare November 26, 2024 03:33
@mergify mergify bot merged commit 1dd4589 into master Nov 26, 2024
81 checks passed
@mergify mergify bot deleted the 10563-vsk-functions branch November 26, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed calls to readFully method of client-utils package
2 participants