Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(agoric-cli): Condense agoric wallet show output #10519

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

gibson042
Copy link
Member

Description

Render empty purses/usedInvitations/offers on one line rather than three:

 {
   "purses": [
     ["board0074",0]
   ],
-  "usedInvitations": [
-
-  ],
-  "offers": [
-
-  ]
+  "usedInvitations": [],
+  "offers": []
 }

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

n/a

Upgrade Considerations

We don't guarantee stability of the output AFAIK, and I'm not aware of anything that depends upon it.

@gibson042 gibson042 requested a review from turadg November 18, 2024 22:58
@gibson042 gibson042 requested a review from a team as a code owner November 18, 2024 22:58
Copy link

cloudflare-workers-and-pages bot commented Nov 18, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 35895bc
Status: ✅  Deploy successful!
Preview URL: https://6106795f.agoric-sdk.pages.dev
Branch Preview URL: https://gibson-2024-11-condense-agor.agoric-sdk.pages.dev

View logs

Render empty purses/usedInvitations/offers on one line rather than three:
```diff
 {
   "purses": [
     ["board0074",0]
   ],
-  "usedInvitations": [
-
-  ],
-  "offers": [
-
-  ]
+  "usedInvitations": [],
+  "offers": []
 }
```
@gibson042 gibson042 force-pushed the gibson-2024-11-condense-agoric-wallet-show branch from dc4c764 to 83298e2 Compare November 19, 2024 15:33
@gibson042 gibson042 added the automerge:squash Automatically squash merge label Nov 20, 2024
@mergify mergify bot merged commit 3ba7ca7 into master Nov 20, 2024
81 checks passed
@mergify mergify bot deleted the gibson-2024-11-condense-agoric-wallet-show branch November 20, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:squash Automatically squash merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants