-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast USDC a3p deployment proposal #10517
Conversation
Deploying agoric-sdk with Cloudflare Pages
|
We're losing here... const USDCissuer = await E(agoricNames).lookup('issuer', 'USDC'); until we get this update... |
a1cc02c
to
cb784a6
Compare
Adding the USDC PSM is going agonizingly slowly. Let's try a work-around: use USDC_axl if USDC isn't handy. |
@michaelfig @turadg I'm not sure how to get such a chain running...
Do we publish the use images? If so, |
In the interest of landing this ASAP, perhaps the docs could follow in a later PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but will defer approval to others, I don't think I know enough about a3p to validate
chainName: 'agoriclocal', | ||
}; | ||
|
||
test('fastUsdc is in agoricNames.instance', async t => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this doesn't run until @agoric/synthetic-chain spins up the chain and stuff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right; deploy.test.js
is invoked by test.sh
, which is invoked in the TEST
stage. See docs on stages.
const configurations = { | ||
A3P_INTEGRATION: { | ||
oracles: { | ||
gov1: 'agoric1ee9hr0jyrxhy999y755mp862ljgycmwyp4pl7q', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering, where do all these accounts come from? I'm guessing we have the private keys somewhere so that a script can use them? I recognize gov1 and gov2 from emerynet at least...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same question. please include a comment on how where these values come from and when they'd need updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh... right... the OCW operator addresses are not necessarily the same as the oracle operators.
* Look up USDC issuer. Since it's not available in some test | ||
* contexts, use USDC_axl as a fall-back. | ||
* | ||
* UNTIL https://github.com/Agoric/agoric-3-proposals/issues/19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections to this personally
"license": "Apache-2.0", | ||
"dependencies": { | ||
"@agoric/client-utils": "0.1.1-dev-02c06c4.0", | ||
"@agoric/synthetic-chain": "^0.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use the latest
"type": "module", | ||
"license": "Apache-2.0", | ||
"dependencies": { | ||
"@agoric/client-utils": "0.1.1-dev-02c06c4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should just be dev
. the specific sha will be in yarn.lock
.
consider integrating with the latest in agoric-sdk
using yarn link
https://github.com/Agoric/agoric-sdk/blob/dcd05b441beb52656411ec0d33d7ed6484ff6b14/a3p-integration/README.md#build-details
const configurations = { | ||
A3P_INTEGRATION: { | ||
oracles: { | ||
gov1: 'agoric1ee9hr0jyrxhy999y755mp862ljgycmwyp4pl7q', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same question. please include a comment on how where these values come from and when they'd need updating
efbb882
to
0c62a98
Compare
darn. since I first got it green, we changed the contract; now it's looking for stuff in agoricNames:
https://github.com/Agoric/agoric-sdk/actions/runs/11940762406/job/33284140491?pr=10517#step:9:958 I gather the plan is to put it in the contract's |
1a8ff01
to
5a7eb01
Compare
- d:quick-send -> f:fast-usdc - init-orch overtaken by u17 - punt test-lib in favor of @agoric/client-utils - --oracleSet option - @endo/init dep
... PFM / chainHub stuff
5a7eb01
to
9b771d3
Compare
closes: #10492
Description
Adds
f:fast-usdc
that invokesinit-fast-usdc.js
and such.Security / Scaling / Upgrade Considerations
Nothing novel to this PR.
Documentation Considerations
DRAFT until:
Testing Considerations
tests that
agoricNames.instance.fastUsdc
is present.includes a work-around for...