Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast USDC a3p deployment proposal #10517

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Fast USDC a3p deployment proposal #10517

merged 5 commits into from
Nov 21, 2024

Conversation

dckc
Copy link
Member

@dckc dckc commented Nov 18, 2024

closes: #10492

Description

Adds f:fast-usdc that invokes init-fast-usdc.js and such.

Security / Scaling / Upgrade Considerations

Nothing novel to this PR.

Documentation Considerations

DRAFT until:

  • Update a3p-integration documentation with how to get a chain running at a particular post-proposal configuration.

Testing Considerations

tests that agoricNames.instance.fastUsdc is present.

includes a work-around for...

Copy link

cloudflare-workers-and-pages bot commented Nov 18, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9b771d3
Status: ✅  Deploy successful!
Preview URL: https://afdf7bde.agoric-sdk.pages.dev
Branch Preview URL: https://10492-a3p-fast-usdc.agoric-sdk.pages.dev

View logs

@dckc
Copy link
Member Author

dckc commented Nov 18, 2024

We're losing here...

  const USDCissuer = await E(agoricNames).lookup('issuer', 'USDC');

until we get this update...

@dckc dckc force-pushed the 10492-a3p-fast-usdc branch from a1cc02c to cb784a6 Compare November 19, 2024 19:27
@dckc
Copy link
Member Author

dckc commented Nov 19, 2024

Adding the USDC PSM is going agonizingly slowly. Let's try a work-around: use USDC_axl if USDC isn't handy.

@dckc
Copy link
Member Author

dckc commented Nov 19, 2024

@michaelfig @turadg I'm not sure how to get such a chain running...

Update a3p-integration documentation with how to get a chain running at a particular post-proposal configuration.

Do we publish the use images? If so, docker run ...use-image or docker compose up -d with a suitable docker-compose.yaml should work, yes?

@dckc
Copy link
Member Author

dckc commented Nov 19, 2024

In the interest of landing this ASAP, perhaps the docs could follow in a later PR?

@dckc dckc marked this pull request as ready for review November 19, 2024 20:31
@dckc dckc requested a review from a team as a code owner November 19, 2024 20:31
Copy link
Contributor

@samsiegart samsiegart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will defer approval to others, I don't think I know enough about a3p to validate

chainName: 'agoriclocal',
};

test('fastUsdc is in agoricNames.instance', async t => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this doesn't run until @agoric/synthetic-chain spins up the chain and stuff?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right; deploy.test.js is invoked by test.sh, which is invoked in the TEST stage. See docs on stages.

const configurations = {
A3P_INTEGRATION: {
oracles: {
gov1: 'agoric1ee9hr0jyrxhy999y755mp862ljgycmwyp4pl7q',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, where do all these accounts come from? I'm guessing we have the private keys somewhere so that a script can use them? I recognize gov1 and gov2 from emerynet at least...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same question. please include a comment on how where these values come from and when they'd need updating

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh... right... the OCW operator addresses are not necessarily the same as the oracle operators.

* Look up USDC issuer. Since it's not available in some test
* contexts, use USDC_axl as a fall-back.
*
* UNTIL https://github.com/Agoric/agoric-3-proposals/issues/19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections to this personally

"license": "Apache-2.0",
"dependencies": {
"@agoric/client-utils": "0.1.1-dev-02c06c4.0",
"@agoric/synthetic-chain": "^0.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the latest

"type": "module",
"license": "Apache-2.0",
"dependencies": {
"@agoric/client-utils": "0.1.1-dev-02c06c4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should just be dev. the specific sha will be in yarn.lock.

consider integrating with the latest in agoric-sdk using yarn link https://github.com/Agoric/agoric-sdk/blob/dcd05b441beb52656411ec0d33d7ed6484ff6b14/a3p-integration/README.md#build-details

const configurations = {
A3P_INTEGRATION: {
oracles: {
gov1: 'agoric1ee9hr0jyrxhy999y755mp862ljgycmwyp4pl7q',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same question. please include a comment on how where these values come from and when they'd need updating

@dckc dckc requested a review from turadg November 19, 2024 23:37
@dckc dckc added the automerge:rebase Automatically rebase updates, then merge label Nov 20, 2024
@dckc dckc force-pushed the 10492-a3p-fast-usdc branch from efbb882 to 0c62a98 Compare November 20, 2024 19:56
@dckc
Copy link
Member Author

dckc commented Nov 21, 2024

darn. since I first got it green, we changed the contract; now it's looking for stuff in agoricNames:

#33 49.91 2024-11-20T20:05:10.907Z SwingSet: ls: v72: Error: chain not found:agoric

https://github.com/Agoric/agoric-sdk/actions/runs/11940762406/job/33284140491?pr=10517#step:9:958

I gather the plan is to put it in the contract's chainHub instead.
This seems familiar... I think I did it for orca.contract.js...

@dckc dckc force-pushed the 10492-a3p-fast-usdc branch 2 times, most recently from 1a8ff01 to 5a7eb01 Compare November 21, 2024 01:44
@dckc dckc force-pushed the 10492-a3p-fast-usdc branch from 5a7eb01 to 9b771d3 Compare November 21, 2024 02:01
@mergify mergify bot merged commit 83191e7 into master Nov 21, 2024
81 checks passed
@mergify mergify bot deleted the 10492-a3p-fast-usdc branch November 21, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a3p proposal deploying Fast USDC
3 participants