chore(SwingSet): Improve anachrophobia messages #10469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
1b6eb14
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1797d914.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-2024-11-anachrophobia.agoric-sdk.pages.dev |
mhofman
approved these changes
Nov 18, 2024
warner
approved these changes
Dec 7, 2024
| @@ -107,7 +108,9 @@ export function makeSyscallSimulator( | |||
| let replayError; // sticky | |||
|
|
|||
| const explain = () => { | |||
| console.log(`anachrophobia strikes ${vatID} on delivery ${deliveryNum}`); | |||
| console.log( | |||
| `anachrophobia strikes ${vatID} syscalls for delivery ${deliveryNum}`, | |||
There was a problem hiding this comment.
Grammar nit, maybe "anachrophobia strikes vatID for syscalls on delivery deliveryNum"? It's the vat that's at fault, and it faulted during a delivery.
| if (!expected) { | ||
| syscallStatus.push('extra'); | ||
| const error = Error(`anachrophobia in ${vatID}: extra syscall`); | ||
| const error = Error(`${context}: extra syscall at index ${idx}`); |
There was a problem hiding this comment.
I've been using sc123 locally when marking syscall numbers (like b123 for block heights, c123 for cranks, d123 for deliveryNums), maybe this could say at index sc${idx} to reinforce the fact that we're talking about a syscallNum which could be correlated with one in a slogfile.
gibson042
added a commit
that referenced
this pull request
Dec 9, 2024
… in anachrophobia messages delivery d$N, syscall sc$N #10469 (comment)
… in anachrophobia messages delivery d$N, syscall sc$N #10469 (comment)
gibson042
force-pushed
the
gibson-2024-11-anachrophobia-cleanup
branch
from
cd33813 to
1b6eb14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from an error investigation in #10165.
Also capitalizes
WRONG/MISSING/EXTRAaftersc[${idx}]:, for increased visual distinction.Security Considerations
None known; any consumer aware of vatIDs should also be allowed to know delivery numbers and constituent syscalls.
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
n/a
Upgrade Considerations
None known; this kernel output should be independent of consensus (and will be consistent across nodes using the same kernel code anyway).