-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(a3p-integration): Update "swap into IST" to force the default gas limit #10451
test(a3p-integration): Update "swap into IST" to force the default gas limit #10451
Conversation
// Export these from synthetic-chain? | ||
const USDC_DENOM = NonNullish(process.env.USDC_DENOM); | ||
const PSM_PAIR = NonNullish(process.env.PSM_PAIR).replace('.', '-'); | ||
|
||
const runCommand = makeRunCommand({ Buffer, Readable, setImmediate, spawn }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm reluctant to make a new API for what Execa offers. Can you make the case for this? (Or convert to use Execa?)
Execa has ambient authority, but I think that's acceptable in testing libs. Pretty sure that's in our guidelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it looks like execa can handle everything we care about. I'll see about refactoring on top of it after CI passes with this.
Deploying agoric-sdk with Cloudflare Pages
|
6adae43
to
5faf4dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some requests but not blocking since you're just merging this into the base.
I'm fine reviewing the base after this is in there. If you land the base and this goes on top of master instead, please address before merge.
...[`--node=${rpcAddrs[0]}`, `--chain-id=${chainName}`], | ||
...[`--keyring-backend=test`, `--from=${address}`], | ||
...['tx', 'swingset', 'wallet-action', '--allow-spend', offer], | ||
...['-ojson', '-bblock'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the dots? If it's for grouping, I think comment lines would be clearer
...[`--node=${rpcAddrs[0]}`, `--chain-id=${chainName}`], | |
...[`--keyring-backend=test`, `--from=${address}`], | |
...['tx', 'swingset', 'wallet-action', '--allow-spend', offer], | |
...['-ojson', '-bblock'], | |
// chain | |
`--node=${rpcAddrs[0]}`, `--chain-id=${chainName}`, | |
// account | |
`--keyring-backend=test`, `--from=${address}`, | |
// transaction | |
'tx', 'swingset', 'wallet-action', '--allow-spend', offer, | |
// output | |
'-ojson', '-bblock', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to use concat
in alignment with execSwingsetTransaction
. The above style doesn't work because our lint configuration prohibits array literals in which some but not all elements share a line.
...defaulting to `--gas=auto --gas-adjustment=1.2`.
5faf4dc
to
58272b4
Compare
Description
Extracted from #10165 and extends #10447.
-bblock
)--gas=auto
)Security Considerations
None known.
Scaling Considerations
None known.
Documentation Considerations
The CLI is self-documenting:
Testing Considerations
The new
--gas=auto
default is used every except "swap into IST", which is now explicitly responsible for covering the "default gas with automatic wallet provisioning" scenario.Upgrade Considerations
This will now detect any future change that pushes PSM swap gas consumption beyond the default limit.