refactor(internal): Separate pure-JS vs. Hardened JS utils #10442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
f875bb0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ec7d796e.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-2024-11-js-utils.agoric-sdk.pages.dev |
gibson042
changed the title
turadg
approved these changes
Nov 11, 2024
| @@ -40,6 +40,8 @@ import { AuctionState } from './util.js'; | |||
| * @import {PriceAuthority, PriceDescription, PriceQuote, PriceQuoteValue, PriceQuery,} from '@agoric/zoe/tools/types.js'; | |||
| */ | |||
|
|
|||
| const BASIS_POINTS = 10_000n; | |||
There was a problem hiding this comment.
There is defined 14 times. I maintain it's worth keeping in a common constants, but that's not useful unless it's also imported. Regardless I agree it's not part of a utils module. So no objection to this change and it can be consolidated separately (at which point the 14 times will become 1).
gibson042
force-pushed
the
gibson-2024-11-js-utils
branch
from
6d63949 to
080c1b5
Compare
gibson042
force-pushed
the
gibson-2024-11-js-utils
branch
from
080c1b5 to
f875bb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #10165.
Best reviewed by individual commits, because the introduction of
deepCopyJsonableis a bit noisy.Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
n/a
Upgrade Considerations
n/a