ci: dont version private packages #10333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
d25c131
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e7fde083.agoric-sdk.pages.dev |
| Branch Preview URL: | https://rs-ci-fix-dirty-tree.agoric-sdk.pages.dev |
mujahidkay
reviewed
Oct 24, 2024
rabi-siddique
force-pushed
the
rs-ci-fix-dirty-tree
branch
from
902b8e8 to
d25c131
Compare
rabi-siddique
changed the title
mujahidkay
approved these changes
Oct 24, 2024
rabi-siddique
added
the
automerge:rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, the
getting-startedjobs in CI have been failing, as seen in this run:https://github.com/Agoric/agoric-sdk/actions/runs/11489549535/job/31978567100
https://github.com/Agoric/agoric-sdk/actions/runs/11493429719/job/31989112054?pr=10323
The issue is due to a missing
CHANGELOG.mdfile in thepackages/fast-usdcfolder. During the CI process, the scriptscripts/registry.shruns the following command in thepublishfunction:This command uses
Lernato version the packages, a part of which involves updating theCHANGELOG.mdfiles for each package. Since theCHANGELOG.mdfile is missing in thefast-usdcpackage, Lerna creates one. This results in a dirty Git tree(There is a check for that), causing subsequent steps in the workflow to fail and leading to the CI job failure.This PR has been created to add an
--no-privateto avoid versioning private packages. Thanks to @mujahidkay for this suggestion.Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations