Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stub Fast USDC CLI #10330

Merged
merged 5 commits into from
Oct 23, 2024
Merged

stub Fast USDC CLI #10330

merged 5 commits into from
Oct 23, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Oct 23, 2024

refs: #10328

Description

Sets up a package for Fast USDC and stubs out its CLI.

Finishing #10328 will require a contract that has the offer makers.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

This will need end user documentation later

Testing Considerations

basic test

Upgrade Considerations

not deployed

@turadg turadg requested a review from dckc October 23, 2024 22:13
@turadg turadg requested a review from a team as a code owner October 23, 2024 22:13
@turadg turadg added the bypass:integration Prevent integration tests from running on PR label Oct 23, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 23, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3275e08
Status: ✅  Deploy successful!
Preview URL: https://018f4a92.agoric-sdk.pages.dev
Branch Preview URL: https://10328-fu-cli.agoric-sdk.pages.dev

View logs

@turadg turadg requested a review from samsiegart October 23, 2024 22:26
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not take on execa for this.

packages/fast-usdc/test/cli.test.ts Outdated Show resolved Hide resolved
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡vamos!

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Oct 23, 2024
"name": "fast-usdc",
"private": true,
"version": "0.1.0",
"description": "Create an Agoric Javascript smart contract application",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems generic, is there a better description we can give?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, good catch. that was copied from create-dapp. I'll fix it in a future PR or this one if I need to rev CI

@mergify mergify bot merged commit d85c025 into master Oct 23, 2024
87 checks passed
@mergify mergify bot deleted the 10328-fu-cli branch October 23, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge bypass:integration Prevent integration tests from running on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants