bump Express to v5 #10310
Merged
bump Express to v5 #10310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Please run cd agoric-sdk && yarn to regenerate the yarn.lock, since the committed yarn.lock is not entirely fresh, causing CI failures.
forward patch
Used only for dev. The tests pass so it works. This doesn't have the property override mistake
turadg
force-pushed
the
ta/hardened-express
branch
from
3b7198f to
c057563
Compare
Deploying agoric-sdk with
|
| Latest commit: |
f6d71a7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://015ec77c.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-hardened-express.agoric-sdk.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evergreen
Description
#10303 failed on forwarding the
expresspatch. That patch is to work around #8513 which is still a problem in the latest 4.x of Express:https://github.com/expressjs/express/blob/4.x/lib/router/index.js#L519
Fortunately, they recently released a v5
https://github.com/expressjs/express/releases/tag/v5.0.0
This bumps the two packages that use
expressto use that latest version.For the
solopackage, some changes were needed to the path expression, explained in https://expressjs.com/en/guide/migrating-5.html#path-syntaxSecurity Considerations
none
Scaling Considerations
none
Documentation Considerations
Should the research on v4 vs v5 go in endojs/endo#2037 ?
Testing Considerations
CI
Upgrade Considerations
none, doesn't run on chain