Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow getBundleIDFromInstallation to be called with a promise #10304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: allow getBundleIDFromInstallation to be called with a promise #10304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/zoe/src/typeGuards.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ export const ZoeServiceI = M.interface('ZoeService', {
getInstallationForInstance: M.callWhen(M.await(InstanceHandleShape)).returns(
M.eref(M.remotable('Installation')),
),
getBundleIDFromInstallation: M.call(InstallationShape).returns(
getBundleIDFromInstallation: M.callWhen(M.await(InstallationShape)).returns(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISTR @dtribble pointing out a security concern where a client can pass a promise and not resolve it, tying up resources in zoe.

Much of the zoe API already accepts promises in this way, so perhaps we have already accepted the risk. But I'd like to be sure.

@warner ? @erights ? thoughts?

M.eref(M.string()),
),

Expand Down
Loading