chore(a3p): setup the oracle and push price for ATOM and stATOM at use phase of f:replace-price-feeds
#10296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
5a3ad84
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4c31fb13.agoric-sdk.pages.dev |
| Branch Preview URL: | https://jorge-verify-pushed-price.agoric-sdk.pages.dev |
There was a problem hiding this comment.
I think this will be unnecessary once #10317 is approved and merged.
|
Hey @Chris-Hibbert , I cannot see where the oracles are registered and a quote is produced durably in #10317. Could you elaborate on how this PR will be unnecessary? I can see that |
This was referenced Oct 24, 2024
|
I thought we had already set up a price push in the use phase of |
Jorge-Lopes
force-pushed
the
jorge/verify-pushed-price
branch
from
a4c52d1 to
d59c30e
Compare
Chris-Hibbert
approved these changes
Oct 28, 2024
Jorge-Lopes
force-pushed
the
jorge/verify-pushed-price
branch
from
d59c30e to
573c565
Compare
Jorge-Lopes
force-pushed
the
jorge/verify-pushed-price
branch
from
573c565 to
8d45260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/Agoric/BytePitchPartnerEng/issues/26
refs: https://github.com/Agoric/BytePitchPartnerEng/issues/22
Description
This PR introduces a new script,
verifyPushedPrice, which is executed during theusephase of then:upgrade-nextproposal.The purpose of this script is to set up the oracle and push an initial price for key brands such as Atom and stAtom. This functionality ensures that a price quote is available for the subsequent proposals and acceptance tests.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
The existing test file,
priceFeedUpdate.test.js, has been updated to account for the new price feed calls made during the use phase, as well as take advantage of the new helper functions built.Upgrade Considerations