-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add zoe upgrade to upgrade.go #10279
Conversation
a4187d4
to
6baf47f
Compare
Deploying agoric-sdk with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, provided the incarnation number test is OK.
@@ -92,6 +92,10 @@ func unreleasedUpgradeHandler(app *GaiaApp, targetUpgrade string) func(sdk.Conte | |||
// Each CoreProposalStep runs sequentially, and can be constructed from | |||
// one or more modules executing in parallel within the step. | |||
CoreProposalSteps = []vm.CoreProposalStep{ | |||
vm.CoreProposalStepForModules( | |||
// Upgrade Zoe (no new ZCF needed). | |||
"@agoric/builders/scripts/vats/upgrade-zoe.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to suggest an incarnation number test, but it looks like we already have one:
zoe: { incarnation: 2 }, |
It seems likely that this will fail in ci and need updating. But in any case, it's there.
I'll add force:integration to ensure I'm not breaking it. |
Yep:
|
f4733c5
to
4672167
Compare
4672167
to
e846f5e
Compare
refs: #10267
Description
Upgrade Zoe as part of the next software upgrade.
Security Considerations
The new Zoe will add the ability to terminate vats from bootstrap space.
Scaling Considerations
Terminating vats will allow us to address some space leakage issues.
Documentation Considerations
The new behavior is accessible on a facet that is only exposed to the bootstrap space. Doesn't need to impact developer docs.
Testing Considerations
Tested in a bootstrap test.
Upgrade Considerations
We expect to include this change with the next software upgrade, so we can start making use of the ability to remove unneeded vats.