Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zoe upgrade to upgrade.go #10279

Merged
merged 2 commits into from
Oct 23, 2024
Merged

feat: add zoe upgrade to upgrade.go #10279

merged 2 commits into from
Oct 23, 2024

Conversation

Chris-Hibbert
Copy link
Contributor

refs: #10267

Description

Upgrade Zoe as part of the next software upgrade.

Security Considerations

The new Zoe will add the ability to terminate vats from bootstrap space.

Scaling Considerations

Terminating vats will allow us to address some space leakage issues.

Documentation Considerations

The new behavior is accessible on a facet that is only exposed to the bootstrap space. Doesn't need to impact developer docs.

Testing Considerations

Tested in a bootstrap test.

Upgrade Considerations

We expect to include this change with the next software upgrade, so we can start making use of the ability to remove unneeded vats.

@Chris-Hibbert Chris-Hibbert added Zoe package: Zoe contract-upgrade next-release about next agoric-sdk or endo release labels Oct 16, 2024
@Chris-Hibbert Chris-Hibbert self-assigned this Oct 16, 2024
@Chris-Hibbert Chris-Hibbert requested a review from a team as a code owner October 16, 2024 00:23
Copy link

cloudflare-workers-and-pages bot commented Oct 22, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: e846f5e
Status: ✅  Deploy successful!
Preview URL: https://4267acda.agoric-sdk.pages.dev
Branch Preview URL: https://10267-zoeupgrade.agoric-sdk.pages.dev

View logs

@Chris-Hibbert Chris-Hibbert requested a review from dckc October 22, 2024 18:01
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, provided the incarnation number test is OK.

@@ -92,6 +92,10 @@ func unreleasedUpgradeHandler(app *GaiaApp, targetUpgrade string) func(sdk.Conte
// Each CoreProposalStep runs sequentially, and can be constructed from
// one or more modules executing in parallel within the step.
CoreProposalSteps = []vm.CoreProposalStep{
vm.CoreProposalStepForModules(
// Upgrade Zoe (no new ZCF needed).
"@agoric/builders/scripts/vats/upgrade-zoe.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest an incarnation number test, but it looks like we already have one:

It seems likely that this will fail in ci and need updating. But in any case, it's there.

@Chris-Hibbert Chris-Hibbert added the force:integration Force integration tests to run on PR label Oct 22, 2024
@Chris-Hibbert
Copy link
Contributor Author

It seems likely that this will fail in ci and need updating. But in any case, it's there.

I'll add force:integration to ensure I'm not breaking it.

@Chris-Hibbert
Copy link
Contributor Author

It seems likely that this will fail in ci and need updating. But in any case, it's there.

Yep:

  Difference (- actual, + expected):

    {
    ....
      zoe: {
  -     incarnation: 3,
  +     incarnation: 2,
      },
    }

@Chris-Hibbert Chris-Hibbert added the automerge:rebase Automatically rebase updates, then merge label Oct 23, 2024
@mergify mergify bot merged commit 7b8c83c into master Oct 23, 2024
80 checks passed
@mergify mergify bot deleted the 10267-ZoeUpgrade branch October 23, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge contract-upgrade force:integration Force integration tests to run on PR next-release about next agoric-sdk or endo release Zoe package: Zoe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants