chore(acceptance): add tests for PSM to z:acceptance
#10273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilhelvaci
force-pushed
the
anil/psm-tests
branch
from
b167d7d to
0c1ae50
Compare
Deploying agoric-sdk with
|
| Latest commit: |
11b336b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f7e884db.agoric-sdk.pages.dev |
| Branch Preview URL: | https://anil-psm-tests.agoric-sdk.pages.dev |
This comment was marked as resolved.
This comment was marked as resolved.
turadg
reviewed
Oct 17, 2024
anilhelvaci
force-pushed
the
anil/psm-tests
branch
2 times, most recently
from
324d3ee to
712f970
Compare
|
Addressed all change requests outside of #10273 (comment). Should I ask for a re-review once the last one is done as well? @turadg |
turadg
approved these changes
Oct 20, 2024
dckc
reviewed
Oct 23, 2024
dckc
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
The tests cover the 6 requested items (New user can complete a swap, ...).
This approval presumes you'll address any lint failures, as usual. No need to re-request review once you've done that.
I found it a little challenging to navigate the split between psm.test.js and psm-lib.js in some places. I made some suggestions about factoring. Those are suggestions; feel free to act on them, respond to them, or ignore them, at your discretion.
anilhelvaci
force-pushed
the
anil/psm-tests
branch
2 times, most recently
from
d50ed58 to
d48faaf
Compare
Refs: Agoric/BytePitchPartnerEng#23 fix(acceptance-psm): address change requests
anilhelvaci
force-pushed
the
anil/psm-tests
branch
from
d48faaf to
11b336b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/Agoric/BytePitchPartnerEng/issues/23
Description
Current version of
z:acceptancetests do not cover PSM at all. The goal of this PR is to make sure we cover test cases in https://github.com/Agoric/BytePitchPartnerEng/issues/23 prepared by @otoole-brendanSecurity Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
The tests assume that
anchorPerMintedratio is 1. I think this is a safe assumption because;boottests for the PSM has the same assumptionUSDC_axlinstance which is something we shouldn't worry about anytime soon.Upgrade Considerations
None.