SPIKE: prototype participants in Fast USDC sequence diagram #10254

dckc · 2024-10-10T19:29:43Z

refs: #10231

Description

quick & dirty prototype based on an early Fast USDC sequence diagram

Security Considerations

The contract code needs a careful scrub before anyone relies on it heavily.

Scaling Considerations

The detailed baseline computron count in this PR might be useful to track scaling issues going forward.

Documentation Considerations

not much

Testing Considerations

This includes several sorts of tests:

unit: tx lifecycle: heavily mocked unit test with diagram participants reified as object
bootstrap: watcher: accept, report: initial performance measurement, in computrons
a3p: quickSend is in agoricNames.instance - supports deployment on a running chain

Upgrade Considerations

early prototype. doesn't involve upgrading anything that's already on chain

cloudflare-workers-and-pages · 2024-10-10T19:33:29Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`74d293b`
Status:	✅ Deploy successful!
Preview URL:	https://e155bce6.agoric-sdk.pages.dev
Branch Preview URL:	https://dc-quicksend.agoric-sdk.pages.dev

View logs

dckc · 2024-10-11T13:20:33Z

currently corresponds pretty closely to...

sequence diagram

The numbered arrows in the diagram correspond to --> #1 etc. in the t.log(...) messages:

~/projects/agoric-sdk/packages/orchestration
17:34 connolly@bldbox$ yarn test test/examples/quickSend-tx.test.ts 
yarn run v1.22.22
$ ava test/examples/quickSend-tx.test.ts

  ✔ tx lifecycle (708ms)
    ℹ -- SETUP...
    ℹ chain agoric1 makeAccount agoric112
    ℹ chain agoric1 makeAccount agoric113
    ℹ chain agoric1 makeAccount agoric114
    ℹ vtransfer register {
        addr: 'agoric113',
        handler: {
          onReceive: AsyncFunction {},
        },
      }
    ℹ  agoric112 balance += 2000 = 2000
    ℹ eth advance to block 9877
    ℹ  noble1mint balance += 100000 = 100000
    ℹ ERC20 transfer {
        dest: '0xUrsula',
        numTokens: 150,
        sender: '0xcircle',
        srcBal: 10000,
      }
    ℹ -- SETUP done.
    ℹ --> #1: app got settlementBase agoric113
    ℹ chain dydx1 makeAccount dydx112
    ℹ --> #2: app initiate {
        amount: 100,
        dest: 'dydx112',
      }
    ℹ watcher found 0 txs at height 9876
    ℹ x/forwarding fwd noble117x112 -> agoric113+dydx112
    ℹ --> #3: express initiate {
        agAddr: 'agoric113+dydx112',
        base: 'agoric113',
        dest: 'dydx112',
        fwd: 'noble117x112',
        nobleFwd: 'noble117x112',
      }
    ℹ --> #4: watcher.startWatchingFor {
        amount: 100,
        dest: 'dydx112',
        nobleFwd: 'noble117x112',
      }
    ℹ watcher found 0 txs at height 9876
    ℹ app watch dest {
        balancePost: 0,
        balancePre: 0,
        dest: 'dydx112',
        tick: 0,
      }
    ℹ --> #5: eth call 0x12 . bridge ( {
        amount: 100,
        dest: 'noble117x112',
      } )
    ℹ --> #6: cctp.bridge: {
        dest: 'noble117x112',
        msg: {
          sender: '0xUrsula',
        },
      }
    ℹ ERC20 transfer {
        dest: '0x0000',
        numTokens: 100,
        sender: '0xUrsula',
        srcBal: 150,
      }
    ℹ waiting 3 blocks (TODO: 20min) before minting on noble
    ℹ eth advance to block 9878
    ℹ watcher found 0 txs at height 9877
    ℹ app watch dest {
        balancePost: 0,
        balancePre: 0,
        dest: 'dydx112',
        tick: 1,
      }
    ℹ eth advance to block 9879
    ℹ watcher found 1 txs at height 9878
    ℹ --> #7: watcher checked 12
    ℹ --> #8: watcher confirmed {
        amount: 100,
        dest: 'dydx112',
        nobleFwd: 'noble117x112',
      }
    ℹ --> #9: contract.releaseAdvance {
        amount: 100,
        dest: 'dydx112',
      }
    ℹ --> #10: orch acct agoric112 txfr 95 to dydx112
    ℹ --> #11: ibc transfer 95 to dydx112
    ℹ  agoric1IBCburn balance += 95 = 95
    ℹ  dydx112 balance += 95 = 95
    ℹ app watch dest {
        balancePost: 95,
        balancePre: 0,
        dest: 'dydx112',
        tick: 2,
      }
    ℹ eth advance to block 9880
    ℹ watcher found 0 txs at height 9879
    ℹ eth advance to block 9881
    ℹ watcher found 0 txs at height 9880
    ℹ  noble117x112 balance += 100 = 100
    ℹ --> #12: fwd {
        amount: 100,
        dest: 'noble117x112',
        fwd: 'agoric113+dydx112',
      }
    ℹ --> #13: ibc transfer 100 to agoric113+dydx112
    ℹ  noble1IBCburn balance += 100 = 100
    ℹ  agoric113 balance += 100 = 100
    ℹ vtransfer to virtual address {
        agAddr: 'agoric113',
        extra: 'dydx112',
      }
    ℹ --> #14: tap onReceive {
        amount: 100,
      }
    ℹ --> #15: orch acct agoric113 send 98 to agoric112
    ℹ --> #16: orch acct agoric113 send 2 to agoric114
    ℹ  agoric112 balance += 98 = 2003
    ℹ  agoric114 balance += 2 = 2
    ℹ eth advance to block 9882
    ℹ watcher found 0 txs at height 9881
    ℹ eth advance to block 9883
    ℹ watcher found 0 txs at height 9882
    ℹ eth advance to block 9884
    ℹ watcher found 0 txs at height 9883
    ℹ quiesced for 5 ticks
    ℹ watcher: stop at 9883
    ℹ actual result {
        dest: {
          addr: 'dydx112',
          balance: 95,
        },
        fee: {
          addr: 'agoric114',
          balance: 2,
        },
        pool: {
          addr: 'agoric112',
          balance: 2003,
          start: 2000,
        },
        settlement: {
          addr: 'agoric113',
          balance: 0,
        },
        user: {
          addr: '0xUrsula',
          balance: 50,
          start: 150,
        },
      }
  ─

  1 test passed
Done in 1.50s.

2024-10-10 14:29 cd6e57d chore(quickSend): skip bootstrap test (WIP)
2024-10-10 14:03 9556ca3 refactor: move contract logic to .contract.js file
2024-10-10 13:35 a2fabd8 test: move makeEthChain to match sequence diagram order
2024-10-10 13:27 f78c43d test: sync arrow labels with sequence diagram
2024-10-10 11:59 ff5f6ab test: separate setup
2024-10-10 05:39 b41eae2 test(quickSend): reify lifecycle participants, incl. settlement
2024-10-09 19:11 becc761 test: reify participants from Fast USDC sequence diagram (part 1)
2024-10-09 14:36 d33f900 refactor(start-quickSand): factor out makePublishingStorageKit
2024-09-19 14:43 fc62b02 test: bootstrap test for trivial quickSend contract

github-actions · 2024-10-23T23:08:31Z

Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label.

0xpatrickdev · 2024-10-24T22:44:21Z

packages/fast-usdc/contract/quickSend.flows.js

+  const fundingPool = await agoric.makeAccount();
+  const settlement = await agoric.makeAccount();
+  const feeAccount = await agoric.makeAccount();


Can fee account be a Purse? Only fundingPool and settlement might need to send or accept IBC transfers?

In recent discussion, I confirmed with @sufyaankhan that it should be a normal cosmos account that the fee beneficiary creates before the contract launches; that way, they can withdraw at will using normal tx bank send.

But I suppose it could be a Seat, yes. (a Purse would give the contract direct access; we avoid that, normally)

turadg

I said I think it's better to have something in master than nothing, but I want to qualify that. We should land the things we know even if they're incomplete. But there's some stuff to figure out around naming that I think we should nail down before this goes to master (so as not to teach people the wrong names and structure).

This PR still serves as a prototype even while open. Whenever someone's work depends on part of this let's land it. And if we get this to a point where what's known and what's temporary is clear, then let's land all of it.

Meanwhile, please PR the SwingSet changes in a PR to be reviewed by Kernel team. Maybe with a load test of some contract that's already in master. Perhaps price feeds because we want to optimize them at some point.

turadg · 2024-10-25T16:48:06Z

a3p-integration/proposals/d:quick-send/package.json

+    "source": "subdir",
+    "sdk-generate": [
+      "vats/init-orchestration.js",
+      "orchestration/init-quickSend.js"


in fast-usdc now, yes?

I'm reluctant to have quickSend around as a synonym for fast-usdc but we could use that to mean "the prototype". But what would be more clear is to call it that, like fu-prototype. Let's try to get the naming of things figured out before merging this, and document it in the fast-usdc README.md

dckc · 2024-10-28T17:41:29Z

Meanwhile, please PR the SwingSet changes in a PR to be reviewed by Kernel team.

chore: let makeRunUtils caller provide run policy #10348

Maybe with a load test of some contract that's already in master. Perhaps price feeds because we want to optimize them at some point.

I forgot that part... let's see if it's easy...

0xpatrickdev

Nice work 👏

0xpatrickdev · 2024-10-24T23:45:19Z

packages/orchestration/src/utils/address.js

+export const NobleCalc = harden({
+  // XXX mock only
+  fwdAddressFor: dest => `noble1${dest.length}${dest.slice(-4)}`,
+});


Is this just for testing? if yes, can we move this to a /test directory?

yes, it's just for testing.

0xpatrickdev · 2024-10-28T21:38:53Z

packages/fast-usdc/contract/quickSend.flows.js

+ * @param {QuickSendAccounts & Passable} accts
+ * @param {import('./client-types.js').CCTPTxEvidence} offerArgs
+ */
+export const handleCCTPCall = async (_orch, ctx, accts, offerArgs) => {


Is it worth stubbing a notifier/subscriber for the Oracle, or adding a comment that denotes this behavior?

elaborate? I don't understand what you mean.

I wanted us to represent the Oracle Feed in a separate exo, but probably OK to punt on for now

in a couple tests: $ cd agoric-sdk/packages/boot $ SWINGSET_WORKER_TYPE=xsnap yarn test test/bootstrapTests/price-feed-replace.test.ts ... ✔ setupVaults; run updatePriceFeeds proposals (1m 27.6s) ℹ setPrice computrons 65536531n $ SWINGSET_WORKER_TYPE=xsnap yarn test test/bootstrapTests/orchestration.test.ts ... ✔ stakeAtom - smart wallet (13.8s) ℹ makeAccount computrons 15231491n

- part 1: send advance - part 2: settlement - sync arrow labels with sequence diagram

- support $SWINGSET_WORKER_TYPE

... and include contract, tools

- genesis vs. validator etc. - kubectl vs docker compose - skip mint100; gov1 has plenty - avoid tsx dep

## Description Support computron measurements in boostrap tests for performance testing by letting `makeRunUtils` caller provide a way to make a run policy. ### Security Considerations A swingset controller relies on the run policy to be well-behaved. But the caller of `makeRunUtils` can only shoot themselves in the foot. ### Scaling Considerations helps measure scaling issues ### Documentation Considerations JSDocs with static types provide adequate docs for an internal tool such as this. ### Testing Considerations Integration with a couple bootstrap tests is included. See also #10254 . ### Upgrade Considerations n/a

turadg · 2024-12-16T17:34:30Z

Helpful research. Not intended to merge or update at this point.

dckc mentioned this pull request Oct 11, 2024

spike for load testing Fast USDC #10231

Closed

dckc self-assigned this Oct 18, 2024

dckc force-pushed the dc-quickSend branch 6 times, most recently from c42fbd6 to 6c05e8c Compare October 23, 2024 23:06

dckc changed the base branch from master to 10328-fu-cli October 23, 2024 23:07

Base automatically changed from 10328-fu-cli to master October 23, 2024 23:08

0xpatrickdev reviewed Oct 24, 2024

View reviewed changes

dckc requested a review from iomekam October 24, 2024 22:53

dckc marked this pull request as ready for review October 24, 2024 22:53

dckc requested a review from a team as a code owner October 24, 2024 22:53

dckc force-pushed the dc-quickSend branch from bb44e47 to 0fa115a Compare October 25, 2024 02:22

turadg requested changes Oct 25, 2024

View reviewed changes

docs: missing typeof

dd751ff

dckc mentioned this pull request Oct 28, 2024

chore: let makeRunUtils caller provide run policy #10348

Merged

0xpatrickdev reviewed Oct 28, 2024

View reviewed changes

dckc added 7 commits October 29, 2024 13:45

chore: let makeRunUtils caller provide run policy

ef9f55e

refactor: factor out computronCounter

d699361

test(boot): thread computron counter thru test context

8d2793b

test: bootstrap test for trivial quickSend contract

f3883e4

chore(quickSend): skip bootstrap test (WIP)

1620ffc

test: reify participants from Fast USDC sequence diagram

368cbeb

- part 1: send advance - part 2: settlement - sync arrow labels with sequence diagram

dckc and others added 24 commits November 4, 2024 12:28

chore: support $SLOGFILE in quickSend perf test

60832db

chore: mock registerAsset in quickSend-tx.test

23b2c41

refactor: fast-usdc files to own package

da6949b

test(fast-usdc): tx lifecycle no longer failing

38ac63f

test(fast-usdc): restore quickSend boot test

1375ac1

- support $SWINGSET_WORKER_TYPE

chore(deps): avoid cycle by pruning agoric

85bae1d

chore(fast-usdc): turn off compilerOptions.strict

652c459

... and include contract, tools

chore(deps): fast-usdc devDependencies

bfe06a0

chore(deps): fast-usdc contract dependencies

7c7d238

docs(fast-usdc): WIP: initAccounts @ts-expect-error

f10b43b

docs(fast-usdc): types for .flows

f8aebcf

test(fast-usdc): types for agoric-mock

eedcfdf

refactor: simplify io in quick-load.test

8beb9db

v0.0.0

9326496

chore(fast-usdc): use CCTPTxEvidence in flows

f000b5b

test(fast-usdc): update mocks to use CCTPTxEvidence in logs

1e15177

docs: refine type of NobleCalc.fwdAddressFor

cc8d0a0

test: re-integrate computron counter

5787716

test: update bootstrap test for CCTPTxEvidence

e5352f1

chore(fast-usdc): move IST/USDC kludge from core-eval to test

1fbd6f8

chore(fast-usdc): fee account pre-exists contract

631684a

chore(fast-usdc): docker-compose file for ad-hoc deployment testing

0e9f794

chore: copy deploy-cli and deps from dapp-orch

bedff43

chore: port deploy-cli for ad-hoc deployment

66e17e6

- genesis vs. validator etc. - kubectl vs docker compose - skip mint100; gov1 has plenty - avoid tsx dep

dckc force-pushed the dc-quickSend branch from 95a612c to 66e17e6 Compare November 4, 2024 18:28

dckc added 2 commits November 4, 2024 12:46

feat: support scriptArgs in deploy-cli

d736cb0

KLUDGE: USDC_axl

74d293b

turadg closed this Dec 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SPIKE: prototype participants in Fast USDC sequence diagram #10254

SPIKE: prototype participants in Fast USDC sequence diagram #10254

dckc commented Oct 10, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 10, 2024 •

edited

Loading

dckc commented Oct 11, 2024

github-actions bot commented Oct 23, 2024

0xpatrickdev Oct 24, 2024

dckc Oct 24, 2024

turadg left a comment

turadg Oct 25, 2024

dckc commented Oct 28, 2024

0xpatrickdev left a comment

0xpatrickdev Oct 24, 2024

dckc Oct 29, 2024

0xpatrickdev Oct 28, 2024

dckc Oct 29, 2024

0xpatrickdev Oct 30, 2024 •

edited

Loading

turadg commented Dec 16, 2024

SPIKE: prototype participants in Fast USDC sequence diagram #10254

SPIKE: prototype participants in Fast USDC sequence diagram #10254

Conversation

dckc commented Oct 10, 2024 • edited Loading

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

cloudflare-workers-and-pages bot commented Oct 10, 2024 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

dckc commented Oct 11, 2024

github-actions bot commented Oct 23, 2024

0xpatrickdev Oct 24, 2024

Choose a reason for hiding this comment

dckc Oct 24, 2024

Choose a reason for hiding this comment

turadg left a comment

Choose a reason for hiding this comment

turadg Oct 25, 2024

Choose a reason for hiding this comment

dckc commented Oct 28, 2024

0xpatrickdev left a comment

Choose a reason for hiding this comment

0xpatrickdev Oct 24, 2024

Choose a reason for hiding this comment

dckc Oct 29, 2024

Choose a reason for hiding this comment

0xpatrickdev Oct 28, 2024

Choose a reason for hiding this comment

dckc Oct 29, 2024

Choose a reason for hiding this comment

0xpatrickdev Oct 30, 2024 • edited Loading

Choose a reason for hiding this comment

turadg commented Dec 16, 2024

dckc commented Oct 10, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 10, 2024 •

edited

Loading

0xpatrickdev Oct 30, 2024 •

edited

Loading