Fix orch.getChain() race
#10225
Merged
Fix orch.getChain() race
#10225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Oct 4, 2024
| @@ -195,7 +244,9 @@ test.serial('asset / denom info', async t => { | |||
| }); | |||
| } | |||
|
|
|||
| const ag = await orc.getChain('agoric'); | |||
| const agP = orc.getChain('agoric'); | |||
| t.throws(() => orc.getDenomInfo(agDenom)); | |||
mhofman
force-pushed
the
mhofman/10219-fix-getchain-race
branch
from
609867c to
2fe7153
Compare
Deploying agoric-sdk with
|
| Latest commit: |
5b2547f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://88b03a1a.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mhofman-10219-fix-getchain-r.agoric-sdk.pages.dev |
mhofman
force-pushed
the
mhofman/10219-fix-getchain-race
branch
from
2fe7153 to
59795be
Compare
mhofman
force-pushed
the
mhofman/10219-fix-getchain-race
branch
from
59795be to
5b2547f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10219
best reviewed commit-by-commit
Description
Stores a structure in the
chainByNamestore with the vow or settled value, allowinggetChainto return the vow for the pending lookup, andgetDenomInfoto continue synchronously returning if the chain info is available.To avoid confusion, this also moves the
chainByNamemap store definition insideprepareOrchestratorKitSecurity Considerations
Nothing new, but
getDenomInfobasically allows probing synchronously for the result of agetChainlookup.Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Added unit tests covering this race
Upgrade Considerations
Contracts can picked up this fix as part of a new orchestration NPM package.