ci: multichain-testing with `go-relayer` #10182

0xpatrickdev · 2024-10-02T17:03:23Z

Description

Enable starship faucet for agoric (required for go-relayer)
Add starship config that uses go-relayer (config.gorelayer.yaml)
update channel-close tests to use go-relayer when RELAYER_TYPE env var is present
Convert multichain-e2e workflow to a template and run hermes and go-relayer jobs in parallel

Security Considerations

n/a, test code

Scaling Considerations

For CI, this uses more resources. We have an additional ubuntu-latest-16core running and another ~30 min job (running in parallel).

Documentation Considerations

Added a section in the README.md with instructions for running the tests with go-relayer.

Testing Considerations

Runs existing test suite against go-relayer, increasing our test coverage across differing infrastructure. Should help identify any relayer-specific issues or discrepancies.

Upgrade Considerations

n/a

cloudflare-workers-and-pages · 2024-10-02T19:11:01Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`a0c73e0`
Status:	✅ Deploy successful!
Preview URL:	https://5388cbc4.agoric-sdk.pages.dev
Branch Preview URL:	https://10179-go-relayer.agoric-sdk.pages.dev

View logs

turadg

Good stuff!

turadg · 2024-10-03T23:20:55Z

.github/workflows/multichain-e2e-template.yml

+
+      - name: Setup Starship Infrastructure
+        id: starship-infra
+        uses: cosmology-tech/[email protected]


why not latest? https://github.com/cosmology-tech/starship-action/releases

Good question. I bumped to 0.5.3 here and will see what CI thinks: #10216

It looks the ability to specify a helm chart version may have been lost starting 0.5.4 (the latest is 0.5.7). I filed an cosmology-tech/starship-action#34 asking for clarification.

We can also bump the helm chart version. We're on 0.2.10 but it's up to 0.2.14. I ran into issues with the new readinessProbe - it seem the approach we provided is not working on my local. I filed cosmology-tech/starship#563 to track this

563 was merged last week. Let's see if we can get an answer on 34 soon enough to incorporate it

turadg · 2024-10-03T23:21:08Z

.github/workflows/multichain-e2e-template.yml

+
+      - name: Setup Starship Infrastructure
+        id: starship-infra
+        uses: cosmology-tech/[email protected]


why not latest? https://github.com/cosmology-tech/starship-action/releases

.github/workflows/multichain-e2e.yml

multichain-testing/package.json

0xpatrickdev · 2024-10-04T17:18:34Z

Hesitant to merge until we see this go through CI multiple times successfully.

I was under the impression each run is fully containerized, but am seeing weird behavior which leads me to believe these are stepping on each other's toes. Both jobs read from and write to the agoric-sdk/multichain-testing filesystem and access the same ports over the network.

Any folks with more gh-action-fu have more insights?

turadg

I'll approve when the work-arounds for upstream issues are gone, or there's a conspicuous plan for addressing them.

turadg · 2024-10-15T22:24:11Z

.github/workflows/multichain-e2e-template.yml

+        with:
+          # uses ghcr.io/agoric/agoric-sdk:dev image (latest master)
+          values: ./agoric-sdk/multichain-testing/${{ inputs.config }}
+          port-forward: false


I see in the commit this is just until cosmology-tech/starship#561 is available.

That's helpful but even more important is for the source to say so, to anyone browsing who could then simplify this code.

Incidentally, isn't your PR available now in a starship release?

turadg · 2024-10-15T22:25:42Z

.github/workflows/multichain-e2e-template.yml

+
+      - name: Setup Starship Infrastructure
+        id: starship-infra
+        uses: cosmology-tech/[email protected]


563 was merged last week. Let's see if we can get an answer on 34 soon enough to incorporate it

turadg · 2024-10-15T22:29:33Z

multichain-testing/README.md

@@ -90,6 +90,15 @@ kubectl logs hermes-agoric-gaia-0 --container=relayer --follow
 kubectl logs hermes-osmosis-gaia-0 --container=relayer --follow
 ```

+## Running With a Different Config File


Capital With jarred me but I don't suppose Agoric has an agreed upon Title Case. 😂

- currently, tests were only run using the hermes relayer. now, we test both hermes and go-relayer in CI

- fixes TypeError due to missing `/cosmos.bank.v1beta1.QueryAllBalancesRequest` key on `Proto3Shape`

- factor out to commonSetup - deleteTestKeys only removes keys present in keyring

0xpatrickdev added the force:integration Force integration tests to run on PR label Oct 2, 2024

0xpatrickdev force-pushed the 10179-go-relayer branch 9 times, most recently from cd1daba to 2d38529 Compare October 3, 2024 18:45

0xpatrickdev marked this pull request as ready for review October 3, 2024 19:38

0xpatrickdev requested a review from a team as a code owner October 3, 2024 19:38

0xpatrickdev requested a review from AgoricTriage October 3, 2024 19:38

0xpatrickdev added force:integration Force integration tests to run on PR and removed force:integration Force integration tests to run on PR labels Oct 3, 2024

0xpatrickdev requested review from turadg and LuqiPan October 3, 2024 22:34

turadg reviewed Oct 3, 2024

View reviewed changes

0xpatrickdev force-pushed the 10179-go-relayer branch from 2d38529 to a0ae81b Compare October 4, 2024 15:32

turadg reviewed Oct 15, 2024

View reviewed changes

0xpatrickdev force-pushed the 10179-go-relayer branch 3 times, most recently from f0827ce to 11015a0 Compare October 16, 2024 19:09

0xpatrickdev marked this pull request as draft October 16, 2024 19:16

0xpatrickdev force-pushed the 10179-go-relayer branch 4 times, most recently from fa4b501 to 4414f4c Compare October 17, 2024 00:26

0xpatrickdev force-pushed the 10179-go-relayer branch 5 times, most recently from a486634 to 0cae9dd Compare October 17, 2024 22:35

0xpatrickdev added 2 commits October 17, 2024 18:37

feat: enable faucet on agoric

42cec1d

refactor: generic relayer tools

c7bdd13

0xpatrickdev force-pushed the 10179-go-relayer branch 4 times, most recently from 1780dad to 94f55f1 Compare October 18, 2024 00:07

0xpatrickdev added 7 commits October 17, 2024 20:20

ci: test against go-relayer

a2c01af

- currently, tests were only run using the hermes relayer. now, we test both hermes and go-relayer in CI

feat: support go-relayer rly commands

bfd85ec

chore: bump global retry attempts

9424145

chore: bump deps

1da1448

- fixes TypeError due to missing `/cosmos.bank.v1beta1.QueryAllBalancesRequest` key on `Proto3Shape`

test: log stderr if exec fails

7da3419

refactor: keyring setup

1aa6978

- factor out to commonSetup - deleteTestKeys only removes keys present in keyring

refactor: use useChain from test context

c98b29a

0xpatrickdev force-pushed the 10179-go-relayer branch 2 times, most recently from 522fc15 to c98b29a Compare October 18, 2024 00:27

feat: add retry logic to fund-provision-pool

a0c73e0

0xpatrickdev force-pushed the 10179-go-relayer branch from 82709be to a0c73e0 Compare October 18, 2024 14:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: multichain-testing with `go-relayer` #10182

ci: multichain-testing with `go-relayer` #10182

0xpatrickdev commented Oct 2, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 2, 2024 •

edited

Loading

turadg left a comment

turadg Oct 3, 2024

0xpatrickdev Oct 4, 2024 •

edited

Loading

turadg Oct 15, 2024

turadg Oct 3, 2024

0xpatrickdev commented Oct 4, 2024

turadg left a comment

turadg Oct 15, 2024

turadg Oct 15, 2024

turadg Oct 15, 2024

ci: multichain-testing with go-relayer #10182

Are you sure you want to change the base?

ci: multichain-testing with go-relayer #10182

Conversation

0xpatrickdev commented Oct 2, 2024 • edited Loading

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

cloudflare-workers-and-pages bot commented Oct 2, 2024 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

turadg left a comment

Choose a reason for hiding this comment

turadg Oct 3, 2024

Choose a reason for hiding this comment

0xpatrickdev Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

turadg Oct 15, 2024

Choose a reason for hiding this comment

turadg Oct 3, 2024

Choose a reason for hiding this comment

0xpatrickdev commented Oct 4, 2024

turadg left a comment

Choose a reason for hiding this comment

turadg Oct 15, 2024

Choose a reason for hiding this comment

turadg Oct 15, 2024

Choose a reason for hiding this comment

turadg Oct 15, 2024

Choose a reason for hiding this comment

ci: multichain-testing with `go-relayer` #10182

ci: multichain-testing with `go-relayer` #10182

0xpatrickdev commented Oct 2, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 2, 2024 •

edited

Loading

0xpatrickdev Oct 4, 2024 •

edited

Loading