using governedContractKits in core eval replacing committee and charter #10178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
0fba11e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://60671ce4.agoric-sdk.pages.dev |
| Branch Preview URL: | https://rs-use-governedcontractkits.agoric-sdk.pages.dev |
rabi-siddique
force-pushed
the
rs-faraz-replace-charter
branch
from
cd7809e to
e993aeb
Compare
rabi-siddique
force-pushed
the
rs-use-governedContractKits
branch
from
d9d9bf2 to
ed8b045
Compare
frazarshad
force-pushed
the
rs-faraz-replace-charter
branch
from
e993aeb to
cd7809e
Compare
rabi-siddique
force-pushed
the
rs-use-governedContractKits
branch
from
e0c2baa to
72d59ac
Compare
rabi-siddique
force-pushed
the
rs-use-governedContractKits
branch
from
72d59ac to
8a1f820
Compare
Chris-Hibbert
approved these changes
Oct 1, 2024
| governorCreatorFacet, | ||
| label, | ||
| } of governedContractKitMap.values()) { | ||
| E(creatorFacet).addInstance(instance, governorCreatorFacet, label); |
There was a problem hiding this comment.
There are lots of contracts floating around. let's rename creatorFacet to ecCreatorFacet or committeeCreatorFacet.
There was a problem hiding this comment.
Good point. Made the update.
| const psmKitMap = await permittedPowers.consume.psmKit; | ||
|
|
||
| console.log('RABI', [...governedContractKitsMap.values()]); |
There was a problem hiding this comment.
meant to be dropped?
(I use 'CTH' (my initials) for the same purpose, and have a pre-commit script I run routinely to find phrases which should seldom be submitted. YMMV.)
rabi-siddique
merged commit 8277e1b
into
rs-faraz-replace-charter
61 of 75 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #10134 #10133
Description
This pull request builds on #10166 and #10164. It updates the core eval code to utilize the
governorCreatorFacetfor the governed contracts via thegovernedContractKit. Initially, the aim was to use thegovernedContractKitto access facets from price feed contracts. But since it also includes facets for other governed contracts, I expanded the code to incorporate these as well.Security Considerations
Same as #10166 and #10164
Scaling Considerations
Documentation Considerations
Testing Considerations
Same as specified in #10164
Upgrade Considerations