Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump typescript-eslint to 8.14 #10120

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

turadg
Copy link
Member

@turadg turadg commented Sep 19, 2024

evergreen

Description

Bumps to latest typescript-eslint to git rid of:

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0

YOUR TYPESCRIPT VERSION: 5.6.2

Also bumps eslint-plugin-github to get a compatible dep range.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

  • yarn lint at root passes locally
  • yarn lint in packages/orchestration (had OOMing for me in earlier versions)

Upgrade Considerations

n/a

@turadg turadg requested review from LuqiPan and iomekam September 19, 2024 21:56
@@ -62,8 +62,7 @@ module.exports = {
root: true,
parser: '@typescript-eslint/parser',
parserOptions: {
// Works for us!
EXPERIMENTAL_useProjectService: true,
projectService: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer experimental

Copy link

cloudflare-workers-and-pages bot commented Sep 19, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1956069
Status: ✅  Deploy successful!
Preview URL: https://6dabbc64.agoric-sdk.pages.dev
Branch Preview URL: https://ta-typescript-eslint-8-6.agoric-sdk.pages.dev

View logs

@turadg turadg marked this pull request as draft September 19, 2024 21:58
@turadg
Copy link
Member Author

turadg commented Sep 20, 2024

OOMing locally:

> @agoric/[email protected] lint:eslint
> eslint .

lerna ERR! npm run lint:eslint stderr:

<--- Last few GCs --->

[38242:0x128008000]   135393 ms: Scavenge 4030.0 (4118.6) -> 4026.2 (4136.1) MB, 78.62 / 0.04 ms  (average mu = 0.708, current mu = 0.665) allocation failure;
[38242:0x128008000]   147698 ms: Mark-Compact 4040.1 (4136.3) -> 4031.7 (4144.1) MB, 12250.67 / 0.92 ms  (average mu = 0.493, current mu = 0.056) allocation failure; scavenge might not succeed


<--- JS stacktrace --->

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
----- Native stack trace -----

 1: 0x100bfd53c node::Abort() [/Users/turadg/Library/Application Support/fnm/node-versions/v20.11.0/installation/bin/node]
 2: 0x100bfd73c node::ModifyCodeGenerationFromStrings(v8::Local<v8::Context>, v8::Local<v8::Value>, bool) [/Users/turadg/Library/Application Support/fnm/node-versions/v20.11.0/installation/bin/node]
 3: 0x100d826c4 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, v8::OOMDetails const&) [/Users/turadg/Library/Application Support/fnm/node-versions/v20.11.0/installation/bin/node]
 4: 0x100f56db8 v8::internal::Heap::GarbageCollectionReasonToString(v8::internal::GarbageCollectionReason) [/Users/turadg/Library/Application Support/fnm/node-versions/v20.11.0/installation/bin/node]

mergify bot added a commit that referenced this pull request Sep 20, 2024
incidental

## Description
Cleans up the README per #10121 (comment)

I thought that was too light a PR so it also bumps typescript-eslint (not quite latest because that OOMs: #10120)

Then I remember there are a couple filenames to normalize in examples this does that too.

### Security Considerations
n/a
### Scaling Considerations
n/a

### Documentation Considerations
Improved

### Testing Considerations
CI

### Upgrade Considerations
not deployed
@turadg turadg force-pushed the ta/typescript-eslint-8.6 branch from 12efb61 to 39dadd5 Compare October 11, 2024 16:10
@turadg turadg force-pushed the ta/typescript-eslint-8.6 branch from 39dadd5 to 78aaa62 Compare November 13, 2024 17:20
@turadg turadg changed the title chore(deps): bump typescript-eslint to 8.6.0 chore(deps): bump typescript-eslint to 8.14 Nov 13, 2024
@turadg turadg marked this pull request as ready for review November 13, 2024 17:25
@turadg turadg requested a review from a team as a code owner November 13, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant