chore(swing-store): Consolidate keyType assertions (#10471)

## Description Minor cleanup noticed in passing. ### Security Considerations n/a ### Scaling Considerations n/a ### Documentation Considerations n/a ### Testing Considerations n/a ### Upgrade Considerations n/a
Agoric · Nov 18, 2024 · d1562a1 · d1562a1
1 parent 98e940d
commit d1562a1
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/packages/swing-store/src/exporter.js b/packages/swing-store/src/exporter.js
@@ -133,7 +133,6 @@ export function makeSwingStoreExporter(dirPath, options = {}) {
    * section
    */
   function getHostKV(key) {
-    typeof key === 'string' || Fail`key must be a string`;
     getKeyType(key) === 'host' || Fail`getHostKV requires host keys`;
     // @ts-expect-error unknown
     return sqlKVGet.get(key);

diff --git a/packages/swing-store/src/kvStore.js b/packages/swing-store/src/kvStore.js
@@ -15,6 +15,7 @@ import { Fail } from '@endo/errors';
  * @param {string} key
  */
 export function getKeyType(key) {
+  typeof key === 'string' || Fail`key must be a string`;
   if (key.startsWith('local.')) {
     return 'local';
   } else if (key.startsWith('host.')) {

diff --git a/packages/swing-store/src/swingStore.js b/packages/swing-store/src/swingStore.js
@@ -337,7 +337,6 @@ export function makeSwingStore(dirPath, forceReset, options = {}) {
   const kernelKVStore = {
     ...kvStore,
     set(key, value) {
-      typeof key === 'string' || Fail`key must be a string`;
       const keyType = getKeyType(key);
       keyType !== 'host' || Fail`kernelKVStore refuses host keys`;
       kvStore.set(key, value);
@@ -352,7 +351,6 @@ export function makeSwingStore(dirPath, forceReset, options = {}) {
       }
     },
     delete(key) {
-      typeof key === 'string' || Fail`key must be a string`;
       const keyType = getKeyType(key);
       keyType !== 'host' || Fail`kernelKVStore refuses host keys`;
       kvStore.delete(key);