Skip to content

Commit

Permalink
fixup! feat(vow): abandoned errors are retriable
Browse files Browse the repository at this point in the history
  • Loading branch information
mhofman committed Oct 1, 2024
1 parent ab74dcb commit cb5845a
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions packages/internal/src/upgrade-api.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ harden(isUpgradeDisconnection);
* Returns whether a reason is a 'vat terminated' error generated when an object
* is abandoned by a vat during an upgrade.
*
* Normally we do not want to rely on the `message` of an error object, but this
* is a pragmatic solution to the current state of vat upgrade errors. In the
* future we'd prefer having an error with a cause referencing a disconnection
* object like for promise rejections. See
* https://github.com/Agoric/agoric-sdk/issues/9582
*
* @param {any} reason
* @returns {reason is Error}
*/
Expand Down

0 comments on commit cb5845a

Please sign in to comment.