feat: only add one auctioneer instance to charter

Agoric · Oct 25, 2024 · a109395 · a109395
1 parent 8c0299e
commit a109395
Showing 1 changed file with 17 additions and 15 deletions.
diff --git a/packages/inter-protocol/src/proposals/replaceElectorate.js b/packages/inter-protocol/src/proposals/replaceElectorate.js
@@ -358,28 +358,30 @@ const addGovernorsToEconCharter = async (
     label,
   } of governedContractKitMap.values()) {
     // The auctioneer was updated in this same release, getting values directly
-    if (label === 'auctioneer') {
-      const [auctionUpgradeNewInstance, auctionUpgradeNewGovCreator] =
-        await Promise.all([
-          auctionUpgradeNewInstanceP,
-          auctionUpgradeNewGovCreatorP,
-        ]);
-      // reset after use. auctionUpgradeNewInstance is reset by upgrade-vault.js
-      auctionUpgradeNewGovCreatorProduce.reset();
-
-      await E(ecCreatorFacet).addInstance(
-        auctionUpgradeNewInstance,
-        auctionUpgradeNewGovCreator,
-        label,
-      );
-    } else {
+    // (there might be more than one auctioneer instance, but the others don't
+    // need to be registered.)
+    if (label !== 'auctioneer') {
       await E(ecCreatorFacet).addInstance(
         instance,
         governorCreatorFacet,
         label,
       );
     }
   }
+
+  const [auctionUpgradeNewInstance, auctionUpgradeNewGovCreator] =
+    await Promise.all([
+      auctionUpgradeNewInstanceP,
+      auctionUpgradeNewGovCreatorP,
+    ]);
+  // reset after use. auctionUpgradeNewInstance is reset by upgrade-vault.js
+  auctionUpgradeNewGovCreatorProduce.reset();
+
+  await E(ecCreatorFacet).addInstance(
+    auctionUpgradeNewInstance,
+    auctionUpgradeNewGovCreator,
+    'auctioneer',
+  );
 };
 
 /**