-
Notifications
You must be signed in to change notification settings - Fork 214
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
12 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,9 +48,21 @@ jobs: | |
- name: Install graphviz | ||
run: sudo apt install -y graphviz | ||
|
||
# This is now redundant with Lerna's --reject-cycles but keep it here so we have | ||
# test coverage of this script we use for visualizing the dep graph. | ||
- name: Check for cycles | ||
run: scripts/check-dependency-cycles.sh | ||
|
||
# Releasing SDK builds all packages in this order during `lerna publish`. | ||
# Due to ambient types, certain build orders (from the dependency graph) | ||
# may break the type resolution. Run this in the PR to find out before | ||
# attempting to merge to master. This takes about 1min locally and since | ||
# this job is about 30s in CI doing it here doesn't add to wall wait | ||
# for CI resolution. | ||
- name: Pack packages | ||
# XXX specify 5.6.2 because `yarn lerna` is pulling latest | ||
run: npx [email protected] exec --reject-cycles --concurrency 1 "npm pack" | ||
|
||
################## | ||
# Lint tests | ||
# We run per package bc of https://github.com/typescript-eslint/typescript-eslint/issues/1192 | ||
|