remove orch.makeLocalAccount (#10260)

closes: #10106

## Description
There doesn't seem to be a motivating use case for exposing a maker for a low-level `LocalChainAccount` in the `Orchestrator`, so lets remove it to avoid misdirection. Instead, consumers can call `orch.getChain('agoric').then(c => c.makeAccount())` to get a `LocalOrchestrationAccount`.

### Security Considerations
n/a

### Scaling Considerations
n/a

### Documentation Considerations
docs.agoric.com already reflects this: Agoric/documentation#1208 (comment)

### Testing Considerations
Removing code, so existing tests suffice

### Upgrade Considerations
Library code that will go out in a NPM Orch Release

packages/builders/test/snapshots/orchestration-imports.test.js.md

@@ -366,11 +366,6 @@ Generated by [AVA](https://avajs.dev).
           },
         ],
       },
-      LocalChainAccountShape: Object @match:remotable {
-        payload: {
-          label: 'LocalChainAccount',
-        },
-      },
       OutboundConnectionHandlerI: Object @guard:interfaceGuard {
         payload: {
           defaultGuards: undefined,

packages/orchestration/src/exos/orchestrator.js

@@ -4,14 +4,12 @@ import { pickFacet } from '@agoric/vat-data';
 import { makeTracer } from '@agoric/internal';
 import { Shape as NetworkShape } from '@agoric/network';
 import { Fail, q } from '@endo/errors';
-import { E } from '@endo/far';
 import { M } from '@endo/patterns';
 import {
   DenomInfoShape,
   ChainInfoShape,
   DenomAmountShape,
   DenomShape,
-  LocalChainAccountShape,
 } from '../typeGuards.js';
 
 /**
@@ -36,32 +34,23 @@ const trace = makeTracer('Orchestrator');
 /** @see {Orchestrator} */
 export const OrchestratorI = M.interface('Orchestrator', {
   getChain: M.call(M.string()).returns(Vow$(ChainInfoShape)),
-  makeLocalAccount: M.call().returns(Vow$(LocalChainAccountShape)),
   getDenomInfo: M.call(DenomShape).returns(DenomInfoShape),
   asAmount: M.call(DenomAmountShape).returns(AmountShape),
 });
 
 /**
  * @param {Zone} zone
  * @param {{
- *   asyncFlowTools: AsyncFlowTools;
  *   chainHub: ChainHub;
- *   localchain: Remote<LocalChain>;
- *   makeRecorderKit: MakeRecorderKit;
  *   makeLocalChainFacade: MakeLocalChainFacade;
  *   makeRemoteChainFacade: MakeRemoteChainFacade;
- *   orchestrationService: Remote<CosmosInterchainService>;
- *   storageNode: Remote<StorageNode>;
- *   timerService: Remote<TimerService>;
  *   vowTools: VowTools;
- *   zcf: ZCF;
  * }} powers
  */
 const prepareOrchestratorKit = (
   zone,
   {
     chainHub,
-    localchain,
     makeLocalChainFacade,
     makeRemoteChainFacade,
     vowTools: { watch, asVow },
@@ -148,9 +137,6 @@ const prepareOrchestratorKit = (
             return vow;
           });
         },
-        makeLocalAccount() {
-          return watch(E(localchain).makeAccount());
-        },
         /** @type {HostOf<Orchestrator['getDenomInfo']>} */
         getDenomInfo(denom) {
           const denomDetail = chainHub.getAsset(denom);
@@ -183,17 +169,10 @@ harden(prepareOrchestratorKit);
 /**
  * @param {Zone} zone
  * @param {{
- *   asyncFlowTools: AsyncFlowTools;
  *   chainHub: ChainHub;
- *   localchain: Remote<LocalChain>;
- *   makeRecorderKit: MakeRecorderKit;
  *   makeLocalChainFacade: MakeLocalChainFacade;
  *   makeRemoteChainFacade: MakeRemoteChainFacade;
- *   orchestrationService: Remote<CosmosInterchainService>;
- *   storageNode: Remote<StorageNode>;
- *   timerService: Remote<TimerService>;
  *   vowTools: VowTools;
- *   zcf: ZCF;
  * }} powers
  */
 export const prepareOrchestrator = (zone, powers) => {

packages/orchestration/src/orchestration-api.ts

@@ -91,8 +91,8 @@ export interface Chain<CI extends ChainInfo> {
 
   // "makeAccount" suggests an operation within a vat
   /**
-   * Creates a new account on the remote chain.
-   * @returns an object that controls a new remote account on Chain
+   * Creates a new Orchestration Account on the current Chain.
+   * @returns an object that controls the account
    */
   makeAccount: () => Promise<OrchestrationAccount<CI>>;
   // FUTURE supply optional port object; also fetch port object
@@ -136,11 +136,6 @@ export interface Orchestrator {
       (C extends 'agoric' ? AgoricChainMethods : {})
   >;
 
-  /**
-   * Make a new local (Agoric) ChainAccount
-   */
-  makeLocalAccount: () => Promise<LocalChainAccount>;
-
   /**
    * For a denom, return information about a denom including the equivalent
    * local Brand, the Chain on which the denom is held, and the Chain that

packages/orchestration/src/typeGuards.js

@@ -105,7 +105,6 @@ export const CosmosChainInfoShape = M.splitRecord(
 export const ChainInfoShape = M.splitRecord({
   chainId: M.string(),
 });
-export const LocalChainAccountShape = M.remotable('LocalChainAccount');
 export const DenomShape = M.string();
 
 /** @type {TypedPattern<DenomInfo<any, any>>} */

packages/orchestration/src/utils/start-helper.js

@@ -130,17 +130,10 @@ export const provideOrchestration = (
   });
 
   const makeOrchestrator = prepareOrchestrator(zones.orchestration, {
-    asyncFlowTools,
     chainHub,
-    localchain: remotePowers.localchain,
-    makeRecorderKit,
     makeLocalChainFacade,
     makeRemoteChainFacade,
-    storageNode: remotePowers.storageNode,
-    orchestrationService: remotePowers.orchestrationService,
-    timerService,
     vowTools,
-    zcf,
   });
 
   /**

packages/orchestration/test/snapshots/exports.test.ts.md

@@ -26,7 +26,6 @@ Generated by [AVA](https://avajs.dev).
       'IBCConnectionInfoShape',
       'IBCTransferOptionsShape',
       'ICQMsgShape',
-      'LocalChainAccountShape',
       'OutboundConnectionHandlerI',
       'Proto3Shape',
       'TimestampProtoShape',