Skip to content

Commit

Permalink
build: defer Node 20 compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
turadg committed Dec 8, 2023
1 parent aa9dab8 commit 9373b5a
Show file tree
Hide file tree
Showing 34 changed files with 62 additions and 48 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/after-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['18.x', '20.x']
# TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636
node-version: ['18.x']
steps:
- uses: actions/checkout@v3
with:
Expand Down
43 changes: 28 additions & 15 deletions .github/workflows/test-all-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['18.x', '20.x']
# TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636
node-version: ['18.x']
steps:
- uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -64,7 +65,7 @@ jobs:
- uses: actions/checkout@v3
- uses: ./.github/actions/restore-node
with:
node-version: '20.x'
node-version: '18.x'

# first job also does repo-level linting
- name: lint repo format
Expand All @@ -84,7 +85,7 @@ jobs:
- uses: actions/checkout@v3
- uses: ./.github/actions/restore-node
with:
node-version: '20.x'
node-version: '18.x'

- name: yarn lint rest
run: ./scripts/lint-with-types.sh rest
Expand All @@ -98,7 +99,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['18.x', '20.x', 'xs']
# TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636
engine: ['18.x', 'xs']
steps:
- name: set vars
id: vars
Expand Down Expand Up @@ -189,7 +191,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['18.x', '20.x', 'xs']
# TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636
engine: ['18.x', 'xs']
steps:
- name: set vars
id: vars
Expand Down Expand Up @@ -306,7 +309,8 @@ jobs:
strategy:
matrix:
# test:xs is noop in solo/package.json
engine: ['18.x', '20.x']
# TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636
engine: ['18.x']
steps:
- name: set vars
id: vars
Expand Down Expand Up @@ -347,7 +351,8 @@ jobs:
strategy:
matrix:
# test:xs is noop in cosmic-swingset/package.json
engine: ['18.x', '20.x', 'xs']
# TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636
engine: ['18.x', 'xs']
steps:
- name: set vars
id: vars
Expand Down Expand Up @@ -391,7 +396,8 @@ jobs:
strategy:
matrix:
# test:xs is noop in inter-protocol/package.json
engine: ['18.x', '20.x']
# TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636
engine: ['18.x']
steps:
- name: set vars
id: vars
Expand Down Expand Up @@ -431,7 +437,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['18.x', '20.x', 'xs']
# TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636
engine: ['18.x', 'xs']
steps:
- name: set vars
id: vars
Expand Down Expand Up @@ -472,7 +479,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['18.x', '20.x', 'xs']
# TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636
engine: ['18.x', 'xs']
steps:
- name: set vars
id: vars
Expand Down Expand Up @@ -514,7 +522,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['18.x', '20.x', 'xs']
# TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636
engine: ['18.x', 'xs']
steps:
- name: set vars
id: vars
Expand Down Expand Up @@ -566,7 +575,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['18.x', '20.x', 'xs']
# TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636
engine: ['18.x', 'xs']
steps:
- name: set vars
id: vars
Expand Down Expand Up @@ -607,7 +617,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['18.x', '20.x', 'xs']
# TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636
engine: ['18.x', 'xs']
steps:
- name: set vars
id: vars
Expand Down Expand Up @@ -649,7 +660,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['18.x', '20.x', 'xs']
# TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636
engine: ['18.x', 'xs']
steps:
- name: set vars
id: vars
Expand Down Expand Up @@ -691,7 +703,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['18.x', '20.x', 'xs']
# TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636
engine: ['18.x', 'xs']
steps:
- name: set vars
id: vars
Expand Down
2 changes: 1 addition & 1 deletion golang/cosmos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
},
"main": "src/index.cjs",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"test": "exit 0",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"typescript": "~5.3.2"
},
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"prettier": {
"arrowParens": "avoid",
Expand Down
2 changes: 1 addition & 1 deletion packages/ERTP/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "src/index.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"build": "exit 0",
Expand Down
2 changes: 1 addition & 1 deletion packages/SwingSet/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "src/index.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"bin": {
"vat": "bin/vat"
Expand Down
2 changes: 1 addition & 1 deletion packages/assert/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "src/assert.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"build": "exit 0",
Expand Down
2 changes: 1 addition & 1 deletion packages/base-zone/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"access": "public"
},
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"ava": {
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/boot/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"exported.js"
],
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"ava": {
"extensions": {
Expand Down
2 changes: 1 addition & 1 deletion packages/builders/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"access": "public"
},
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"ava": {
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/cache/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"access": "public"
},
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"ava": {
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/casting/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"access": "public"
},
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"ava": {
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/cosmic-swingset/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"access": "public"
},
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"ava": {
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/deploy-script-support/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "src/helpers.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"build": "exit 0",
Expand Down
2 changes: 1 addition & 1 deletion packages/governance/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "src/index.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"build": "yarn build:bundles",
Expand Down
2 changes: 1 addition & 1 deletion packages/import-manager/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "./src/importManager.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"build": "exit 0",
Expand Down
2 changes: 1 addition & 1 deletion packages/inter-protocol/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "src/index.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"build": "yarn build:bundles",
Expand Down
2 changes: 1 addition & 1 deletion packages/internal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "src/index.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"build": "exit 0",
Expand Down
2 changes: 1 addition & 1 deletion packages/network/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"access": "public"
},
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"ava": {
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/notifier/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "src/index.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"build": "exit 0",
Expand Down
2 changes: 1 addition & 1 deletion packages/pegasus/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "./src/pegasus.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"build": "exit 0",
Expand Down
2 changes: 1 addition & 1 deletion packages/same-structure/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "index.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"build": "exit 0",
Expand Down
2 changes: 1 addition & 1 deletion packages/solo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"access": "public"
},
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"ava": {
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/sparse-ints/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "src/sparseInts.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"build": "exit 0",
Expand Down
2 changes: 1 addition & 1 deletion packages/spawner/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "./src/contractHost.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"build": "yarn build:bundles",
Expand Down
2 changes: 1 addition & 1 deletion packages/store/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "src/index.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"build": "exit 0",
Expand Down
2 changes: 1 addition & 1 deletion packages/swingset-liveslots/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"main": "src/index.js",
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"scripts": {
"build": "exit 0",
Expand Down
2 changes: 1 addition & 1 deletion packages/telemetry/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"access": "public"
},
"engines": {
"node": "^18.12 || ^20.9"
"node": "^18.12"
},
"ava": {
"files": [
Expand Down
Loading

0 comments on commit 9373b5a

Please sign in to comment.